Fix PHP 7.2/7.3 error when calling get_prepared_links and there are no links

westonruter · westonruter · commit 921c2d311fad · 2025-01-21T16:17:37.000-08:00
diff --git a/plugins/optimization-detective/class-od-link-collection.php b/plugins/optimization-detective/class-od-link-collection.php
@@ -114,12 +114,18 @@ public function add_link( array $attributes, ?int $minimum_viewport_width = null
 	 * @return LinkAttributes[] Prepared links with adjacent-duplicates merged together and media attributes added.
 	 */
 	private function get_prepared_links(): array {
+		$links_by_rel = array_values( $this->links_by_rel );
+		if ( count( $links_by_rel ) === 0 ) {
+			// This condition is needed for PHP 7.2 and PHP 7.3 in which array_merge() fails if passed a spread empty array: 'array_merge() expects at least 1 parameter, 0 given'.
+			return array();
+		}
+
 		return array_merge(
 			...array_map(
 				function ( array $links ): array {
 					return $this->merge_consecutive_links( $links );
 				},
-				array_values( $this->links_by_rel )
+				$links_by_rel
 			)
 		);
 	}
