Explicitly autoload od_rest_api_unavailable option

westonruter · westonruter · commit 8926f10844c5 · 2025-01-16T10:12:54.000-08:00
diff --git a/plugins/optimization-detective/site-health.php b/plugins/optimization-detective/site-health.php
@@ -46,7 +46,11 @@ function od_test_rest_api_availability(): array {
 	$response       = od_get_rest_api_health_check_response( false );
 	$result         = od_compose_site_health_result( $response );
 	$is_unavailable = 'good' !== $result['status'];
-	update_option( 'od_rest_api_unavailable', $is_unavailable ? '1' : '0' );
+	update_option(
+		'od_rest_api_unavailable',
+		$is_unavailable ? '1' : '0',
+		true // Intentionally autoloaded since used on every frontend request.
+	);
 	return $result;
 }
 
diff --git a/plugins/optimization-detective/tests/test-site-health.php b/plugins/optimization-detective/tests/test-site-health.php
@@ -157,6 +157,7 @@ public function test_rest_api_availability( $mocked_response, string $expected_o
 		$this->assertArrayHasKey( 'description', $result );
 		$this->assertArrayHasKey( 'test', $result );
 		$this->assertSame( $expected_option, get_option( 'od_rest_api_unavailable', '' ) );
+		$this->assertArrayHasKey( 'od_rest_api_unavailable', wp_load_alloptions(), 'Expected option to be autoloaded.' );
 		$this->assertSame( $expected_status, $result['status'] );
 		$this->assertSame( $expected_unavailable, od_is_rest_api_unavailable() );
 	}

Original file line number	Diff line number	Diff line change
`@@ -157,6 +157,7 @@ public function test_rest_api_availability( $mocked_response, string $expected_o`
`157`	`157`	`$this->assertArrayHasKey( 'description', $result );`
`158`	`158`	`$this->assertArrayHasKey( 'test', $result );`
`159`	`159`	`$this->assertSame( $expected_option, get_option( 'od_rest_api_unavailable', '' ) );`
	`160`	`+ $this->assertArrayHasKey( 'od_rest_api_unavailable', wp_load_alloptions(), 'Expected option to be autoloaded.' );`
`160`	`161`	`$this->assertSame( $expected_status, $result['status'] );`
`161`	`162`	`$this->assertSame( $expected_unavailable, od_is_rest_api_unavailable() );`
`162`	`163`	`}`