Remove redundant anonymous class instantiation

westonruter · dmsnell · westonruter · commit 7a6debcb9ee0 · 2024-04-05T10:37:29.000-07:00
Co-authored-by: dmsnell &lt;dmsnell@git.wordpress.org&gt;
diff --git a/plugins/optimization-detective/class-od-html-tag-processor.php b/plugins/optimization-detective/class-od-html-tag-processor.php
@@ -180,7 +180,7 @@ final class OD_HTML_Tag_Processor {
 	 */
 	public function __construct( string $html ) {
 
-		$processor = new class( $html ) extends WP_HTML_Tag_Processor {
+		$this->processor = new class( $html ) extends WP_HTML_Tag_Processor {
 
 			/**
 			 * Appends HTML to the provided bookmark.
@@ -202,8 +202,6 @@ public function append_html( string $bookmark, string $html ): bool {
 				return true;
 			}
 		};
-
-		$this->processor = new $processor( $html );
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ final class OD_HTML_Tag_Processor {`
`180`	`180`	`*/`
`181`	`181`	`public function __construct( string $html ) {`
`182`	`182`
`183`		`- $processor = new class( $html ) extends WP_HTML_Tag_Processor {`
	`183`	`+ $this->processor = new class( $html ) extends WP_HTML_Tag_Processor {`
`184`	`184`
`185`	`185`	`/**`
`186`	`186`	`* Appends HTML to the provided bookmark.`
`@@ -202,8 +202,6 @@ public function append_html( string $bookmark, string $html ): bool {`
`202`	`202`	`return true;`
`203`	`203`	`}`
`204`	`204`	`};`
`205`		`-`
`206`		`- $this->processor = new $processor( $html );`
`207`	`205`	`}`
`208`	`206`
`209`	`207`	`/**`