Suppress imagedestroy() phpcs complaints

westonruter · westonruter · commit 67dee5918316 · 2025-11-21T22:27:58.000-08:00
diff --git a/plugins/webp-uploads/hooks.php b/plugins/webp-uploads/hooks.php
@@ -947,7 +947,7 @@ function webp_uploads_convert_palette_png_to_truecolor( $file ): array {
 
 	// Check if the image is already truecolor.
 	if ( imageistruecolor( $image ) ) {
-		imagedestroy( $image );
+		imagedestroy( $image ); // phpcs:ignore Generic.PHP.DeprecatedFunctions.Deprecated
 		return $file;
 	}
 
@@ -960,7 +960,7 @@ function webp_uploads_convert_palette_png_to_truecolor( $file ): array {
 		// Overwrite the upload with the new truecolor PNG.
 		imagepng( $image, $file['tmp_name'] );
 	}
-	imagedestroy( $image );
+	imagedestroy( $image ); // phpcs:ignore Generic.PHP.DeprecatedFunctions.Deprecated
 
 	return $file;
 }
diff --git a/plugins/webp-uploads/tests/test-load.php b/plugins/webp-uploads/tests/test-load.php
@@ -1190,7 +1190,7 @@ static function () {
 				$this->assertNotSame( $original_file_hash, $modified_file_hash );
 				$img = imagecreatefrompng( $path );
 				$this->assertTrue( imageistruecolor( $img ) );
-				imagedestroy( $img );
+				imagedestroy( $img ); // phpcs:ignore Generic.PHP.DeprecatedFunctions.Deprecated
 
 				// Make sure the image converted to modern image format is not 0 bytes.
 				$modern_image_format_path = get_attached_file( $attachment_id );

Original file line number	Diff line number	Diff line change
`@@ -947,7 +947,7 @@ function webp_uploads_convert_palette_png_to_truecolor( $file ): array {`
`947`	`947`
`948`	`948`	`// Check if the image is already truecolor.`
`949`	`949`	`if ( imageistruecolor( $image ) ) {`
`950`		`- imagedestroy( $image );`
	`950`	`+ imagedestroy( $image ); // phpcs:ignore Generic.PHP.DeprecatedFunctions.Deprecated`
`951`	`951`	`return $file;`
`952`	`952`	`}`
`953`	`953`
`@@ -960,7 +960,7 @@ function webp_uploads_convert_palette_png_to_truecolor( $file ): array {`
`960`	`960`	`// Overwrite the upload with the new truecolor PNG.`
`961`	`961`	`imagepng( $image, $file['tmp_name'] );`
`962`	`962`	`}`
`963`		`- imagedestroy( $image );`
	`963`	`+ imagedestroy( $image ); // phpcs:ignore Generic.PHP.DeprecatedFunctions.Deprecated`
`964`	`964`
`965`	`965`	`return $file;`
`966`	`966`	`}`