Fix float comparison for intersection ratio

ShyamGadde · westonruter · web-flow · commit 5ecfcf249760 · 2024-11-18T19:17:46.000+05:30
Co-authored-by: Weston Ruter &lt;westonruter@google.com&gt;
diff --git a/plugins/embed-optimizer/class-embed-optimizer-tag-visitor.php b/plugins/embed-optimizer/class-embed-optimizer-tag-visitor.php
@@ -174,7 +174,7 @@ public function __invoke( OD_Tag_Visitor_Context $context ): bool {
 
 				foreach ( $preconnect_hrefs as $preconnect_href ) {
 					foreach ( $context->url_metric_group_collection as $group ) {
-						if ( $group->get_element_max_intersection_ratio( $embed_wrapper_xpath ) <= 0 ) {
+						if ( ! ( $group->get_element_max_intersection_ratio( $embed_wrapper_xpath ) > 0.0 ) ) {
 							continue;
 						}
 

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ public function __invoke( OD_Tag_Visitor_Context $context ): bool {`
`174`	`174`
`175`	`175`	`foreach ( $preconnect_hrefs as $preconnect_href ) {`
`176`	`176`	`foreach ( $context->url_metric_group_collection as $group ) {`
`177`		`- if ( $group->get_element_max_intersection_ratio( $embed_wrapper_xpath ) <= 0 ) {`
	`177`	`+ if ( ! ( $group->get_element_max_intersection_ratio( $embed_wrapper_xpath ) > 0.0 ) ) {`
`178`	`178`	`continue;`
`179`	`179`	`}`
`180`	`180`