fix tests

mehulkaklotar · mehulkaklotar · commit 0fb1e19b2061 · 2022-11-16T14:43:34.000+05:30
diff --git a/tests/modules/images/webp-uploads/load-tests.php b/tests/modules/images/webp-uploads/load-tests.php
@@ -926,29 +926,34 @@ public function it_should_create_mime_types_for_allowed_sizes_only_via_global_va
 	 * @test
 	 */
 	public function it_should_set_quality_with_image_conversion() {
-		$editor = wp_get_image_editor( TESTS_PLUGIN_DIR . '/tests/testdata/modules/images/dice.png', array( 'mime_type' => 'image/png' ) );
-
-		// Quality setting for the source image. For PNG the fallback default of 82 is used.
-		$this->assertSame( 82, $editor->get_quality(), 'Default quality setting for PNG is 82.' );
-
-		// Temporary file.
+		// Temporary file path.
 		$file = wp_tempnam();
 
+		$editor      = wp_get_image_editor( TESTS_PLUGIN_DIR . '/tests/testdata/modules/images/dice.png', array( 'mime_type' => 'image/png' ) );
+		$png_quality = $editor->get_quality();
+
 		// A PNG image will be converted to WebP whose quality should be 82 universally.
 		$editor->save( $file, 'image/webp' );
-		$this->assertSame( 82, $editor->get_quality(), 'Output image format is WebP. Quality setting for it should be 82 universally.' );
-
-		$editor = wp_get_image_editor( TESTS_PLUGIN_DIR . '/tests/testdata/modules/images/leafs.jpg' );
+		$png_to_webp_quality = $editor->get_quality();
 
-		// Quality setting for the source image. For JPG the fallback default of 82 is used.
-		$this->assertSame( 82, $editor->get_quality(), 'Default quality setting for JPG is 82.' );
+		$editor      = wp_get_image_editor( TESTS_PLUGIN_DIR . '/tests/testdata/modules/images/leafs.jpg' );
+		$jpg_quality = $editor->get_quality();
 
 		// A JPG image will be converted to WebP whose quality should be 82 universally.
 		$editor->save( $file, 'image/webp' );
-		$this->assertSame( 82, $editor->get_quality(), 'Output image format is WebP. Quality setting for it should be 82 universally.' );
+		$jpg_to_webp_quality = $editor->get_quality();
 
-		// Delete the temporary file.
+		// Delete the temporary file before assertions.
 		unlink( $file );
+
+		// Quality setting for the source image. For PNG the fallback default of 82 is used.
+		$this->assertSame( 82, $png_quality, 'Default quality setting for PNG is 82.' );
+
+		// Quality setting for the source image. For JPG the fallback default of 82 is used.
+		$this->assertSame( 82, $jpg_quality, 'Default quality setting for JPG is 82.' );
+
+		$this->assertSame( 82, $png_to_webp_quality, 'Output image format is WebP. Quality setting for it should be 82 universally.' );
+		$this->assertSame( 82, $jpg_to_webp_quality, 'Output image format is WebP. Quality setting for it should be 82 universally.' );
 	}
 
 	/**
