The code requires PHP 8, so tell wp-env to use it. #541
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
WordPress contains a compat version of the Any reason this shouldn't be bumped to PHP 8.1 though? (The next version we'll use on WordPress.org) |
Member
|
Is that code outside of WordPress? Asking because of https://github.com/WordPress/wordpress-develop/blob/d2f420493d87465c323190892d4e7a6e4c6070a7/src/wp-includes/compat.php#L440. |
Member
|
Might as well bump it to PHP 8.1 to match production. (I don't think the fatal described in the OP is possible, but this is for unrelated reasons) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase includes a couple of calls to
str_contains(), which is PHP 8.0+ only. It's possible to get a fatal error when running the local environment on 7.4, but that will be the default for some users.This one-liner tells wp-env to use PHP 8.0.