-
Notifications
You must be signed in to change notification settings - Fork 254
Closed
WordPress/openverse-catalog
#865Labels
good first issueNew-contributor friendlyNew-contributor friendlyhelp wantedOpen to participation from the communityOpen to participation from the community🐍 tech: pythonInvolves PythonInvolves Python💻 aspect: codeConcerns the software code in the repositoryConcerns the software code in the repository🟨 priority: mediumNot blocking but should be addressed soonNot blocking but should be addressed soon🧰 goal: internal improvementImprovement that benefits maintainers, not usersImprovement that benefits maintainers, not users
Description
Description
The DelayedRequester has a lot of machinery around making requests & handling errors that would be useful for alternate request methods (such as HEAD or POST). We have a use-case for HEAD already in #1493.
I think an ideal implementation would have one request inner method that is wrapped by the various methods, e.g.:
def make_request(method, **kwargs):
...
def get(**kwargs):
make_request(requests.get, **kwargs):
def head(**kwargs):
make_request(requests.head, **kwargs):
...Implementation
- 🙋 I would be interested in implementing this feature.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueNew-contributor friendlyNew-contributor friendlyhelp wantedOpen to participation from the communityOpen to participation from the community🐍 tech: pythonInvolves PythonInvolves Python💻 aspect: codeConcerns the software code in the repositoryConcerns the software code in the repository🟨 priority: mediumNot blocking but should be addressed soonNot blocking but should be addressed soon🧰 goal: internal improvementImprovement that benefits maintainers, not usersImprovement that benefits maintainers, not users
Type
Projects
Status
✅ Done