Update block registration function docs and signature.#974
Merged
Conversation
mtias
added
[Feature] Block API
Member
|
There were many more instances of "slug" terminology, updated in cf19b31. We also use the same term for block categories and block controls documentation, the latter of which is outdated and should probably be removed/updated. I can see to this. |
Member
Author
|
Thanks, i had to flee in the middle of fixing other cases. |
Member
Author
|
Investigating issue with inserter. |
Member
|
There's quite a few "blockType" occurring in the parser. Should those be updated to "blockName"? |
aduth
force-pushed
the
update/block-registration-function-docs
branch
from
46e3f73 to
1036a3f
Compare
Member
|
Rebased to resolve conflicts, squash, and update parser's "block type" (string) references to "block name". |
youknowriad
approved these changes
Jun 14, 2017
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Didn't find any block slug or wrong blockType reference. 👍
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be consistent about naming.