Standardize alignment options for blocks based off of WP widgets#9557
Closed
ZebulanStanphill wants to merge 5 commits intoWordPress:masterfrom
ZebulanStanphill:update/standardize-alignments-for-widget-blocks
Closed
Standardize alignment options for blocks based off of WP widgets#9557ZebulanStanphill wants to merge 5 commits intoWordPress:masterfrom ZebulanStanphill:update/standardize-alignments-for-widget-blocks
ZebulanStanphill wants to merge 5 commits intoWordPress:masterfrom
ZebulanStanphill:update/standardize-alignments-for-widget-blocks
Conversation
Member
Author
|
Fixed tests that were failing. Ready for feedback and review. |
4 tasks
kjellr
added
[Type] Enhancement
Contributor
|
Hey @ZebulanStanphill — would you mind adding a few screenshots of those blocks to this thread for quick reference? That'll help give us a clear sense of what's changed. Thanks! |
Member
Author
ZebulanStanphill
deleted the
update/standardize-alignments-for-widget-blocks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the blocks based off of WordPress widgets seem to have little to no consistency in what alignment options they support. One would support all alignments while another only supported left, right, and center. Another would support center, wide, and full, but not left and right.
This PR gets rid of all these inconsistencies by making the blocks based off of WordPress widgets all support every alignment option.
It also simplifies the checks for valid alignment values using the
Array.prototype.includesfunction.Additionally, I managed to fix a couple bugs while I was at it:
aligncenterregardless of what is selected in the toolbar #7910.alignnoneclass, which was inconsistent with other blocks.classNameattribute used for custom classes was not defined and was not being appended to the outputclassHTML attribute of the block.)Fixes #7910. Closes #8777. Closes #9413. Solves some cases of #7908, but there are still some cases of that issue that involve non-widget blocks. I think I should tackle those in another PR.