Skip to content

[Enhancement] Establish consistency regarding alignment options between the archives and categories blocks#9469

Merged
gziolo merged 1 commit intoWordPress:masterfrom
nfmohit:update/categories-block/9413
Feb 4, 2019
Merged

[Enhancement] Establish consistency regarding alignment options between the archives and categories blocks#9469
gziolo merged 1 commit intoWordPress:masterfrom
nfmohit:update/categories-block/9413

Conversation

@nfmohit
Copy link
Copy Markdown
Member

@nfmohit nfmohit commented Aug 30, 2018

Description

This PR closes #9413 which suggests the sync up of alignment options in the archives and categories blocks. This removes the "Full" alignment option from the categories block so it stays consistent with the archives block.

How has this been tested?

This PR has been tested by going through the following steps:

  1. Started a new post using the Gutenberg editor.
  2. Added the "Categories" block.
  3. Made sure that the "Full" alignment option doesn't show up in the block alignment toolbar.

Screenshots

pull-9413

Types of changes

This PR just removes the full option from the controls parameter that defined the alignment options in the "Categories" block.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@nfmohit nfmohit mentioned this pull request Aug 30, 2018
Closed
jorgefilipecosta
jorgefilipecosta approved these changes Aug 31, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kjellr kjellr mentioned this pull request Sep 7, 2018
Merged
4 tasks
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Jan 25, 2019 •
edited
Loading

This PR needs to be updated to work with the current implementation of Category block.

gziolo
gziolo requested changes Jan 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment

@ZebulanStanphill
Copy link
Copy Markdown
Member

ZebulanStanphill commented Jan 26, 2019

@gziolo I made a PR that syncs the alignment options of the blocks and also does some code cleanup: #10706

@nfmohit
Copy link
Copy Markdown
Member Author

nfmohit commented Jan 27, 2019

Thank you for the heads-up @gziolo, a refresh is coming up real soon ❤️

@gziolo gziolo mentioned this pull request Jan 28, 2019
Closed
@gziolo gziolo added [Block] Categories Affects the Categories Block [Type] Enhancement A suggestion for improvement. labels Jan 28, 2019
@gziolo gziolo added this to the 5.1 (Gutenberg) milestone Jan 28, 2019
@nfmohit
Copy link
Copy Markdown
Member Author

nfmohit commented Feb 2, 2019

PR refreshed, thank you for the review @gziolo ❤️

@gziolo gziolo merged commit a0dcbfa into WordPress:master Feb 4, 2019
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Feb 4, 2019

@nfmohit-wpmudev thanks for waiting so long to get this PR merged. It should never happen given how easy to reviews this change was. I really appreciate your willingness to refresh this PR so quickly 🥇

@nfmohit
Copy link
Copy Markdown
Member Author

nfmohit commented Feb 5, 2019

Thank you for the merge and for your kind words @gziolo ❤️

daniloercoli added a commit that referenced this pull request Feb 5, 2019
@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
70836f1 
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg: (22 commits)
  Make the modal title styling consistent (#13669)
  Disable navigation block for text mode. (#12185)
  Fix: Linting problem in modal example code (#13671)
  Add myself as a code owner to the annotations (#13672)
  Add more reviewers to CODEOWNERS.md file (#13667)
  Plugin: Remove jQuery heartbeat-to-hooks proxying (#13576)
  Workflow: Add repository CODEOWNERS file (#13604)
  Add a mobile minimum size for form fields (#13639)
  Update edit-save documentation  (#13578)
  Alt image setting (#13631)
  Fix: Allow years lower than 1970 in DateTime component. (#13602)
  Using addQueryArgs to generate Manage All Reusable Blocks link (#13653)
  Bump plugin version to 5.0.0-rc.1 (#13652)
  Update lodash to 4.17.10 (#13651)
  Refreshed PR (#9469)
  Set default values of the width and height input fields according to the actual image dimensions (#7687)
  12647 fix css color picker (#12747)
  Remove "we" from messages (#13644)
  Fix: Font size picker max width on mobile (#13264)
  Fix/issue 12501 menu item aria label
  ...
This was referenced Feb 18, 2019
Merged
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@youknowriad
Refreshed PR (#9469)
856217b
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@youknowriad
Refreshed PR (#9469)
dc19bef
This was referenced Apr 30, 2020
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
This was referenced May 1, 2020
Closed
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gziolo gziolo gziolo approved these changes

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

Assignees

No one assigned

Labels

[Block] Categories Affects the Categories Block [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

5.1 (Gutenberg)

Development

Successfully merging this pull request may close these issues.

Sync up alignment options for the Archives and Categories blocks

4 participants

@nfmohit @gziolo @ZebulanStanphill @jorgefilipecosta