Update: Increase bottom padding on gallery image caption#8459
Closed
johnwatkins0 wants to merge 2 commits intoWordPress:masterfrom
johnwatkins0:update/gallery-image-caption-padding
Closed
Update: Increase bottom padding on gallery image caption#8459johnwatkins0 wants to merge 2 commits intoWordPress:masterfrom johnwatkins0:update/gallery-image-caption-padding
johnwatkins0 wants to merge 2 commits intoWordPress:masterfrom
johnwatkins0:update/gallery-image-caption-padding
Conversation
aduth
added
[Feature] Blocks
Member
|
In theory this could be a good addition but the PR needs refreshing. Could you work on that please @johnwatkins0? |
karmatosed
added
the
[Status] Stale
Member
Author
|
Updated to address staleness, @karmatosed. |
karmatosed
removed
the
[Status] Stale
Contributor
|
Be sure to check the contrast is sufficient when moving the text upwards. |
Member
|
What is missing to land this one? |
Contributor
|
This works well, but just needs a tiny adjustment to the gradient. I was unable to pull the branch down to test (I think the source repo has been deleted), so I created a fresh PR with both changes: #13623 I'll close this issue and we can migrate over there instead. Thanks for getting this going, @johnwatkins0! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This resolves #8018 by increasing the bottom padding of gallery image captions by 4px.
How has this been tested?
Visually verified the change in the editor (in English and in an RTL language) and in the published post.
Types of changes
One character change in an SCSS file.