Block Bindings: Add list item content support#78991
Draft
cbravobernal wants to merge 2 commits into
Draft
Conversation
cbravobernal
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
spacedmonkey
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected]. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Add server-side rendering support so a bound `core/list-item` content attribute is replaced without dropping nested List inner blocks rendered inside the same `<li>`. All logic lives in the wordpress-7.1 compat layer: a `render_block_data` filter hides the binding from Core's generic rich-text replacement, and a `render_block` filter resolves the value through the existing `gutenberg_process_block_bindings()` helper and applies it with a nested-list-aware replacement. The shipped wordpress-6.9 block-bindings code is left untouched and no new hooks are introduced. Adds PHPUnit coverage (plain text, nested/ordered/deep lists, empty value, pattern overrides, sanitization, non-list inner blocks) and an editor e2e test. Builds on WordPress#78947 (list-item block bindings support). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
cbravobernal
force-pushed
the
add/list-item-block-bindings-v2
branch
from
6bcecfa to
dab2d81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds Block Bindings support for the
core/list-itemblock'scontentattribute.Supersedes #78947 by preserving its list-item supported-attribute commit and adding the nested-list-safe render path.
Core backport: WordPress/wordpress-develop#12113.
Why?
List Item stores its rich-text content and nested List inner blocks inside the same
<li>. The generic rich-text binding replacement path can replace the whole<li>contents, which drops nested lists. Supporting this block in the Gutenberg plugin needs to update only the list item's leading rich-text content while preserving nested inner blocks.The compatibility workaround is deliberate: the current block bindings path does not expose a clean seam to resolve a bound value without also replacing the markup. To stay contained, this PR hides list-item content bindings from the generic replacement path, resolves them through the existing resolver later, and applies a list-item-specific replacement.
How?
contentto the server-provided supported attributes forcore/list-itemin the WordPress 7.1 compat layer.render_block_dataso the generic replacement path does not process them first.gutenberg_process_block_bindings()helper, then replaces only the list item rich text with a nested-list-aware HTML processor.wp_kses_post()path, and keeps pattern override__defaultmetadata expansion consistent with the generic path.Future direction
WordPress/wordpress-develop#12113 implements the cleaner Core-side version by recording inner-block render offsets inside
WP_Block::render()and letting rich-text replacement stop at the first inner block. This Gutenberg PR keeps a narrower compat bridge because the plugin cannot change the host CoreWP_Block::render()implementation on older WordPress installs.Testing Instructions
npm run test:unit:php:base -- --filter Tests_Block_Bindings.PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 npm run test:e2e -- test/e2e/specs/editor/various/block-bindings/custom-sources.spec.js --grep "list item".metadata.bindings.content, include a nested List block under it, and confirm the front end renders the bound list item content while keeping the nested list.Testing Instructions for Keyboard
No new keyboard interactions are introduced. Existing List Item editing, indentation, and rich-text keyboard behavior are unchanged.
Screenshots or screencast
Not applicable; this is render and binding compatibility behavior covered by tests.
Use of AI Tools
Claude was used to help author the implementation/tests in the branch commit and Core backport direction, and Codex was used for review passes, metadata cleanup, documentation/backport-changelog updates, and validation. The changes were reviewed before requesting review.