Add template creation for post format archives#78872
Open
carolinan wants to merge 6 commits into
Open
Conversation
Follows the practice that is used by the existing template modal files.
Addressing issue mentioned during code review. From Claude: Fix unnecessary re-creation of post format entry point by wrapping its onClickMenuItem callback in useCallback, preventing the entryPoint useMemo from busting on every render,
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
carolinan
added
[Type] Enhancement
youknowriad
requested review from
a team,
Mamaduka,
ntsekouras and
talldan
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Enables creating block templates for post format archive pages from the “Add template” flow in the Site Editor, aligning post format support with other archive/template creation entry points.
Changes:
- Adds a “Post Format Archives” entry point in the “Add template” modal and a follow-up view for selecting supported post formats.
- Introduces
usePostFormatMenuItemsto derive supported/available post format archive templates based on theme supports and existing templates. - Implements the UI across the three template creation flows (legacy, template activation, and routes-based editor).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/eslint/suppressions.json | Adds ESLint suppression entries for new modal content files. |
| routes/template-list/add-new-template/utils.ts | Adds post format constants/types and usePostFormatMenuItems for the routes-based flow. |
| routes/template-list/add-new-template/index.tsx | Wires the post format entry point into the routes-based “Add template” modal. |
| routes/template-list/add-new-template/add-post-format-template-modal-content.tsx | New routes-based modal content listing available post formats. |
| routes/template-list/add-new-template/add-custom-template-modal-content.tsx | Adjusts containerRef typing to allow null. |
| packages/edit-site/src/components/add-new-template/utils.js | Adds usePostFormatMenuItems for the template-activation flow. |
| packages/edit-site/src/components/add-new-template/index.js | Wires post format entry point + modal view into the template-activation “Add template” modal. |
| packages/edit-site/src/components/add-new-template/add-post-format-template-modal-content.js | New modal content listing available post formats (template-activation flow). |
| packages/edit-site/src/components/add-new-template-legacy/utils.js | Adds usePostFormatMenuItems for the legacy flow. |
| packages/edit-site/src/components/add-new-template-legacy/index.js | Wires post format entry point + modal view into the legacy “Add template” modal. |
| packages/edit-site/src/components/add-new-template-legacy/add-post-format-template-modal-content.js | New modal content listing available post formats (legacy flow). |
Comment on lines
+473
to
+478
| const onClickPostFormatMenuItem = useCallback( | ||
| ( { postFormats } ) => { | ||
| setPostFormats( postFormats ); | ||
| }, | ||
| [ setPostFormats, onClickPostFormats ] | ||
| ); |
|
Size Change: +920 B (+0.01%) Total Size: 8.21 MB 📦 View Changed
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jun 3, 2026
| } from '@wordpress/components'; | ||
| import { decodeEntities } from '@wordpress/html-entities'; | ||
| import { useState, memo, useRef, useEffect } from '@wordpress/element'; | ||
| import { |
Contributor
There was a problem hiding this comment.
@ellatrix it seems this was missed in the renaming of components related to the templates activation experiment. This is not legacy right now and is confusing.
ntsekouras
reviewed
Jun 3, 2026
| import { useViewportMatch } from '@wordpress/compose'; | ||
| import { focus } from '@wordpress/dom'; | ||
|
|
||
| function AddPostFormatTemplateModalContent( { |
Contributor
There was a problem hiding this comment.
This file seems to be identical with the one in the experiment. It feels like we could keep this one here for now (where the folder should be renamed) and import from the folder for the experiment. If something diverges we could then keep separate copies.
ntsekouras
reviewed
Jun 3, 2026
| const isMobile = useViewportMatch( 'medium', '<' ); | ||
|
|
||
| // Focus the first focusable element when the component mounts. | ||
| useEffect( () => { |
Contributor
There was a problem hiding this comment.
Why do we need this?
If there is a solid reason, shouldn't the logic live in the parent modal?
ntsekouras
reviewed
Jun 3, 2026
| * with `entryPoint` (the grid button, or `null` if nothing to show) and | ||
| * `availableFormats` (the list of format templates that can still be created). | ||
| */ | ||
| export function usePostFormatMenuItems( onClickMenuItem ) { |
Contributor
There was a problem hiding this comment.
I guess we could have a single util added and reused (similar to this), since it seems this function and its internal deps are identical between the current and the experiment flows.
Not a strong opinion though because this file has diverged a bit..
It's so easy for the logic to drift with so many places (two experiments) - not from this PR of course.
Contributor
Author
There was a problem hiding this comment.
Yeah we need to make a final decision about what should be covered. Maybe the routes changes should be completely removed.
Contributor
There was a problem hiding this comment.
I know that experiment (in routes) has diverged a bit, but since you already have the code changes I'd say keep them there.
ntsekouras
reviewed
Jun 3, 2026
| } else if ( modalContent === modalContentMap.customGenericTemplate ) { | ||
| modalTitle = __( 'Create custom template' ); | ||
| } else if ( modalContent === modalContentMap.postFormats ) { | ||
| modalTitle = __( 'Post Format Archives' ); |
Contributor
There was a problem hiding this comment.
We should probably not capitalize every word.
ntsekouras
reviewed
Jun 3, 2026
| function useMissingTemplates( | ||
| setEntityForSuggestions, | ||
| onClickCustomTemplate, | ||
| setPostFormats, |
Contributor
There was a problem hiding this comment.
Do we really need both new props? It feels like the formats could be read from usePostFormatMenuItems inside AddPostFormatTemplateModalContent.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #66664
Make it possible for users to create block templates for post format archives.
Why?
Partial post format support has already been added, but template creation was missing.
How?
The PR adds a new option for creating archive templates for post formats from the Editor > Templates > Add Template option.
It adds a new modal content that lists the post formats that are supported by the theme.
Step 1 shows that post format archive templates can be created:
Step 2 lists which post format archive templates that can be created:
There are currently three template creation flows: legacy and the two experiments, template activation and extensible site editor. Meaning, the code is repeated three times and we need to test all three.
The extensible site editor -the routes, does not seem to work fully, the templates can be created, but not edited.
Note that this is for archives only, not single view, since that would require a change to the template hierarchy and is a separate issue.
Testing Instructions
First, activate a block theme with support for post formats, for example Twenty Twenty-Five.
Create at least one post that you assign the video post format. Add any content so that you can recognize the post.
Legacy
Go to Gutenberg > Experiments and make sure that you do NOT have Template Activation or Extensible Site Editor enabled.
Go to Appearance > Editor > Templates.
Select Add template.
Navigate to the "Post Format Archives" button using your keyboard. Activate it (enter or space).
Use the tab key to move one step forward. Confirm that the focus is on the close button.
(From now you can continue using the mouse or whatever you prefer)
Select and create the Video post format archive.
When the block editor opens there should be a popup that suggest using a specific pattern. This should be the themes default archive template.
Edit the template so that you can see the difference between this template and the default archive. Save.
Now go to the front to view that the template is working: /type/post-format-video/
Go to Appearance > Editor > Templates.
Confirm that you can edit or delete the post format archive template. Delete it.
Template activation
Go to Gutenberg > Experiments and enable Template Activation.
Follow all steps as above but notice that during creation, you have more templates to choose from:
Confirm that the post format template can be activated:
Confirm that the post format template can be duplicated and deleted.
Extensible Site Editor
(This is the "routes" file changes):
Go to Gutenberg > Experiments and disable Template Activation and enable Extensible Site Editor.
Follow all steps as above.
You will not be able to edit the template because eh, the route does not exist. I don't know if this is expected at this point of the experiment, any help welcome.
Use of AI Tools
Claude, with code reviews from Copilot and Codex.