UI: Simplify focus ring styles#78823
Open
mirka wants to merge 2 commits into
Open
Conversation
mirka
commented
May 29, 2026
Comment on lines
-17
to
-19
| /* Outline width must be kept at 0 even with a transparent color, | ||
| or else the outline will be visible in forced-colors mode. */ | ||
| outline: 0 solid transparent; |
Member
Author
There was a problem hiding this comment.
I cannot figure out why this was necessary 🤔 Maybe a remnant of a previous implementation.
mirka
commented
May 29, 2026
Comment on lines
-4
to
-10
| .outset-ring--focus, | ||
| .outset-ring--focus-except-active, | ||
| .outset-ring--focus-visible, | ||
| .outset-ring--focus-within, | ||
| .outset-ring--focus-within-except-active, | ||
| .outset-ring--focus-within-visible, | ||
| .outset-ring--focus-parent-visible { |
Member
Author
There was a problem hiding this comment.
This simplification makes it much easier to have consistent focus styles once these styles are shared more widely in a @wordpress/base-styles mixin. People will only need to use one mixin instead of two, and they won't have to think about transitions styles conflicting.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -308 B (0%) Total Size: 8.21 MB 📦 View Changed
ℹ️ View Unchanged
|
jameskoster
reviewed
Jun 1, 2026
| --_gcd-div-outline: var(--wpds-border-width-focus) solid var(--wpds-color-stroke-focus-brand); | ||
|
|
||
| outline: var(--wpds-border-width-focus) solid var(--wpds-color-stroke-focus-brand); | ||
| outline-offset: 1px; |
Contributor
There was a problem hiding this comment.
It might make sense to use a border width token here. I think the idea is that the offset value is always the same as the border width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Simplifies the shared
@wordpress/uifocus ring utility styles, removing the transition and an unused force-colors mode tweak.Why?
The focus ring utility's
transitionshorthand is often overridden by component-level transitions, which makes the focus ring animation inconsistent across call sites.How?
Removes the shared focus ring transition and base outline styles. The utility now applies the outline and outline offset only in the active focus states.
Testing Instructions
Button,Link, or form controls.