Updated PR to match changes from #8287

Any update on this one? I rebased the latest changes from master but not sure if I should refactor anything else.

@jahvi Can you rebase it again? I will test the block on my Gutenberg installation.

@Soean Sure thing, I just rebased it now.

As we focus on phase 1 this will be moving to potential phase 2 and we can then consider it from there, For now, closing and moving to potential blocks for the future.

Thanks for reopening, I just rebased and fixed some code to match the latest Gutenberg changes. I'm not sure how to fix the CI issues, can you guys advise?

Nice work! You have to delete the generated test files and regenerate them.

Delete:

• core__tag-cloud__showTagCounts.json
• core__tag-cloud__showTagCounts.parsed.json
• core__tag-cloud__showTagCounts.serialized.html
• core__tag-cloud.json
• core__tag-cloud.parsed.json
• core__tag-cloud.serialized.html

Run: GENERATE_MISSING_FIXTURES=y npm run test-unit test/integration/full-content/full-content.spec.js

Thanks it should be fixed now, there are some other failing tests still but not sure if they're related to this PR.

@jahvi Can you rebase it again? Then the tests should be correct.
The Gutenberg phase 2 with Widgets to blocks has startet, so I asked in the Core-editor chat for reviews of this PR: https://make.wordpress.org/core/2019/01/17/editor-chat-summary-january-16/

One more thing which I want to confirm. Tag cloud widget is using wrapping div with tagcloud class name. Block uses wrapping p without this class. Is that expected? I personally don't see it as an issue, but maybe we want to stay closer to widgets in terms of syntax. This is how widgets look like:

Is the difference just the underlines? We should keep those.

There is also third option available to Tag Cloud widget which I can't see on the block. Not sure what Link Categories is in the first place but it would be worth investigating.

The site you're using probably is old enough that it had the "Links" section in wp-admin (or maybe we include it in development versions?). Links were hidden from all new sites in 3.5. We should conditionally support that, but it's lower priority IMO since it's a deprecated feature. We can make a new issue/PR for that later.

Can we also make the error messages change based on which taxonomy is chosen?

No categories to show.
No tags to show.

Or even:

Your site doesn't have any categories to show.
Your site doesn't have any tags to show.

I tested this and I feel it's good enough to land to include in Gutenberg 5.1. Follow-up improvements to styling, and messages can happen separately.

Thanks everyone for the collaboration and @jahvi Awesome work

Thanks all for your help, I'll be glad to keep helping improve it.