Move PHP Sync Issue Generator file to @wordpress/release-tools#78456
Conversation
USERSATOSHI
changed the title
|
cc: @manzoorwanijk |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
manzoorwanijk
added
the
[Type] Build Tooling
Thank you for this. Just a heads up. I am currently in Japan for some work-related commitments, and may be slow to respond/review while traveling. I hope to get back to this PR as soon as I am able. |
There was a problem hiding this comment.
Pull request overview
Migrates the PHP Sync Issue Generator from the legacy bin/ scripts area into the @wordpress/release-tools workspace package, updating invocation to run via the workspace while keeping the generated issueContent.md output in the historical location.
Changes:
- Add a
generate-php-sync-issueworkspace script to@wordpress/release-tools. - Update the generator to write
issueContent.mdtobin/issueContent.mdfrom its new location. - Update the root
other:generate-php-sync-issuescript and remove the old script entry frombin/tsconfig.json.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/release/package.json | Adds a workspace script entry to run the generator from @wordpress/release-tools. |
| tools/release/generate-php-sync-issue.mjs | Adjusts output path resolution so the generated markdown lands in bin/issueContent.md. |
| package.json | Updates the root npm script to delegate to the @wordpress/release-tools workspace script. |
| bin/tsconfig.json | Removes the generator from the bin scripts TS config include list after relocation. |
Comments suppressed due to low confidence (1)
tools/release/generate-php-sync-issue.mjs:160
- The output path is hard-coded to
<repoRoot>/bin/issueContent.mdby resolving__dirnameup two levels. This makes the script dependent on the current repo layout and can break if the tool is executed from a different directory structure (or ifbin/isn’t present). Consider making the output path configurable (e.g.--output) and/or defaulting toprocess.cwd()while ensuring the target directory exists before writing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
Thank you. This looks good.
What?
Part of #75041
Migrate PHP Sync Issue Generator file from bin to release-tool workspace package.
Why?
Part of organization of all toolings and this file is supposed to be a follow up phase after the release-tools is merged.
How?
Migrates the file and the update all its references elsewhere to the new location.
Update the code to still use the prev dirname for the issueContent.md
Use of AI Tools
None