Media Editor Modal: Fix unexpected tab stop on date fields in the Details sidebar#78454
Merged
Conversation
andrewserong
added
[Feature] Media
|
Size Change: +16 B (0%) Total Size: 7.97 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 804cfda. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26138090892
|
ramonjd
reviewed
May 20, 2026
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
May 20, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
LGTM
I can no longer do this:
I found that truncated filenames allow tab stops, but it's unrelated to this PR
Contributor
Author
|
Thanks for the speedy review!
Cheers, it's a little obscured but I split the fixes out into two since this PR fixes the media editor's logic and #78453 fixed it for the filename field (i.e. in that case it's the field itself that was causing the problem). Once they're both merged it should be all sorted on trunk. |
Member
Oh, that went over my head 😄 Thanks for confirming! |
Contributor
Author
|
No worries, it wasn't super obvious that the two PRs were related in this flow 😄 |
78 tasks
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of:
Remove the unexpected tab stop in the Details tab of the experimental Media Editor Modal for the date added field (or, well, the date fields that we override in the form component).
Why?
This is a very similar PR to the one to fix the truncation of the filename field (#78453). Currently in trunk, in the details sidebar, if you tab through you unexpectedly land on both the "Date added" and "File name" fields because of their tooltips. #78453 fixes the file name field, and this PR fixes the Date added field.
In principle, what we want is for the full field value to be available to screen readers (and either be in the DOM markup or in an
aria-labelattribute) and for the tooltip to be available via hover. These fields should not create tab stops as they are otherwise non-interactive and are not buttons or input fields.How?
tabIndex={ -1 }to ensure the overridden field does not create a tab stoparia-labelattributeTesting Instructions
Date addedfield.Screenshots or screencast
This is the field I'm talking about. If you tab down from the close button you shouldn't be able to land on the "Date added" field, but the Tooltip should still be available on hover.
Use of AI Tools
Claude Code