Stylelint: Add logical properties exemptions#78252
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.95 MB ℹ️ View Unchanged
|
aduth
approved these changes
May 13, 2026
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍 I wonder if it'd be better to just do some blanket /(bottom|top|x|y|width|height)/ regex matching if we're not concerned about anything other than left/right specifically. Am I following that right?
Member
Author
That would be convenient actually, but it looks like this particular plugin doesn't support regex matching here. |
Member
Ah, I think I was looking at the docs for a different plugin that had this feature when suggesting this 🙈 Maybe that one could work better for us if this ends up causing a lot of ongoing maintenance. |
arthur791004
added
the
[Type] Build Tooling
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In preparation for #76744 (comment)
Adds a few more properties to the
plugin/use-logical-properties-and-valuesignore list:border-bottomandborder-topoverflow-xandoverflow-yscroll-margin-topandscroll-margin-bottomWhy?
This is preparation for enabling logical property linting across the
routesfolders. These properties do not affect RTL directionality, so flagging them creates noise while auditing the route stylesheets for physical directional properties that do need to be converted.Testing Instructions
npm run lint:css.