Embed: Tighten raw URL transform isMatch#78021
Merged
Merged
Conversation
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
May 6, 2026
6 tasks
|
Size Change: +33 B (0%) Total Size: 7.95 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in c8f45a6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25481771022
|
ntsekouras
approved these changes
May 7, 2026
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
Let's try that. Thanks!
Member
Author
|
Thanks for the review, Nik! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #74734.
PR improves the
type: 'raw'isMatchfor the embed block transform:isURL()from@wordpress/urlfor proper URL validation (rejects malformed inputs likehttps:// foo).https://only —http://embeds aren't supported.https://prefixes (was countinghttps, also fixes brittle matching).getFilename(). Such URLs should be treated as file/image/video/audio blocks, not embeds.<br>-joined URL guard — concatenated URLs with no whitespace still get rejected.Testing Instructions
https://www.youtube.com/watch?v=dQw4w9WgXcQTesting Instructions for Keyboard
Same.
Use of AI Tools
Claude to validate regexes.