Media Editor Modal: Use shift modifier to adjust keyboard pan speed#77878
Merged
ramonjd merged 1 commit intoMay 1, 2026
Merged
Conversation
andrewserong
added
[Feature] Media
andrewserong
changed the title
|
Size Change: +1 B (0%) Total Size: 7.87 MB 📦 View Changed
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in c0b4235. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25206152789
|
ramonjd
approved these changes
May 1, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
nice one
makes it more consistent with keyboard crop resize 👍🏻
ramonjd
deleted the
update/media-editor-modal-use-shift-modified-to-adjust-pan-speed
branch
Contributor
Author
|
Thanks for merging! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of:
Just like we do for keyboard handling of the resize handles, this PR adds in a shift modifier to adjust the speed of keyboard panning for the cropper.
Why?
Sometimes you want a little more precision when moving the crop area by keyboard, and sometimes you want to go a little faster. Also, it's more consistent if it works the same for panning as for the crop drag handles.
How?
getKeyboardStepfunction to handle the swiftTesting Instructions
Enable the Media Upload Modal experiment
Add an image to a post or page and click the crop icon in the block toolbar to invoke the modal.
Reduce the size of the crop area, and either tab to the cropper or drag it to ensure it's focused. Then, use the cursor keys on the keyboard to interact with it. Then, hold the Shift key while doing the same. Does it work as expected?
Screenshots or screencast
2026-05-01.17.18.21.mp4
Use of AI Tools
Codex