RTC: Provide PROTOCOL_MISMATCH error handling#76991
Merged
Merged
Conversation
chriszarate
added
[Type] Task
|
Size Change: +213 B (0%) Total Size: 7.97 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in dd2c4e2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26107033750
|
github-project-automation
Bot
moved this to 🔎 Needs Review
in WordPress 7.0 Editor Tasks
Contributor
|
Real-time collaboration will not ship in WordPress 7.0, so let's punt this to 7.1. |
t-hamano
removed
the
Backport to WP 7.0 Beta/RC
t-hamano
moved this from 🔎 Needs Review
to 🦵 Punted to 7.1
in WordPress 7.0 Editor Tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…t isPolling) on protocol mismatch error + matching tests
…INITIAL_DISCONNECTED_DEBOUNCE_MS timeout
Contributor
|
Merged trunk, added some recent room unregister improvements (5a8c2f8), and ensured we don't wait 20 seconds to show the dialog if it's a protocol mismatch and show it immediately (bb6bf1b). I tested this by adding this filter temporarily to add_filter(
'rest_pre_dispatch',
function ( $result, $server, $request ) {
if ( '/wp-sync/v1/updates' === $request->get_route() ) {
return new WP_Error(
'rest_sync_protocol_mismatch',
'Protocol mismatch (test)',
array( 'status' => 426 )
);
}
return $result;
},
10,
3
);Then, open a post and see the dialog: protocol-error-example.movAdditionally, here's what it looks like if a user receives protocol-error-ongoing.movNote that nothing actually fires these yet, they're just for future use when we do need a protocol change. |
alecgeatches
approved these changes
May 18, 2026
github-project-automation
Bot
moved this from 🦵 Punted to 7.1
to ✅ Done
in WordPress 7.0 Editor Tasks
arthur791004
removed
the
[Type] Task
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Provide error handling for future
PROTOCOL_MISMATCHerror.Why?
While this error currently does not exist, providing handling for it will allow it to be used during future upgrades.
IMPORTANT: This PR does not provide a way for users to save the post in progress. Either path (allowing save or not allowing save) potentially results in data loss.
How?
Add new error code and handling.