Home Link: Add missing controls#76672
Conversation
im3dabasia
added
[Type] Enhancement
prasadkarmalkar
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
juanfra
left a comment
juanfra
left a comment
There was a problem hiding this comment.
Thanks so much for the PR! I left a few comments. The edit button is missing.
I also updated the issue, as we are staying conservative with the rel option and we're keeping that as is.
| } | ||
| /> | ||
| </ToolsPanelItem> | ||
| { homeUrl && ( |
There was a problem hiding this comment.
To be consistent with the other navigation blocks, we need to include the link to edit the front/home page before the "View".
We probably want to get all the data we need from the useSelect above, as there are more things we need to implement the edit. We likely want the front-page data, and we can also leverage onNavigateToEntityRecord so that we can navigate directly to edit the home/front-page. Here's a reference of how it's done in other places.
There was a problem hiding this comment.
Updated it with the Edit button and removed rel option and keeping it as it is
There was a problem hiding this comment.
Thanks for the changes @prasadkarmalkar! Code looks good and it is testing well.
Can you please check the failing tests? It seems that we need to update the fixture.
|
Hi @juanfra , Fixed the issue with failing tests |
juanfra
left a comment
juanfra
left a comment
There was a problem hiding this comment.
Thanks for working on this, @prasadkarmalkar! LGTM
3 participants
What?
Closes #76589
Why?
How?
Testing Instructions
Screenshots or screencast