Changelog: Add missing label-to-feature mappings#76646
Conversation
Add mappings for labels that were causing PRs to appear uncategorized in the generated changelog: - `[Tool] ESLint plugin` → Tools - `[Package] DataViews` → DataViews - `[Package] Core Data` → Data Layer - `Connectors screen` → Connectors - `[Package] UI` → Components - `[Package] Compose` → Components - `[Package] Theme` → Components - `Design System` → Components
aduth
left a comment
There was a problem hiding this comment.
Makes sense 👍
Separately, this raises a couple thoughts:
- I wonder how we can proactively address these issues in the future. This feels similar to the type of problem I'm trying to address in #76263, for example.
- On labeling conventions, "Connectors screen" doesn't feel entirely consistent. Is it a feature (i.e. should have "[Feature]" prefix)? It doesn't feel broad enough to be unscoped like others which are unscoped.
| '[Package] E2E Tests': 'Testing', | ||
| '[Package] E2E Test Utils': 'Testing', | ||
| '[Type] Automated Testing': 'Testing', | ||
| 'Connectors screen': 'Connectors', |
There was a problem hiding this comment.
This is the only "new" category, as I understand. We don't have to do anything special to make that work properly, do we?
There was a problem hiding this comment.
For generating the changelog there's nothing more we need to do - it really is just that simple.
Point taken about the label name not being scoped properly though. @jorgefilipecosta / @gziolo should the Connectors screen label be renamed to [Feature] Connectors screen ?
|
Size Change: 0 B Total Size: 8.76 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in d0c5743. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23263259407
|
It's been a few days without an answer, so I've merged. @jorgefilipecosta / @gziolo if you decide to rename the |
What?
Adds missing label-to-feature mappings in the changelog generation script so PRs are correctly categorized.
Why?
During the Gutenberg 22.8 release, many PRs appeared uncategorized in the generated changelog because their GitHub labels weren't mapped to changelog sub-headings. This was especially noticeable for Connectors, DataViews, Core Data, UI, Compose, and Theme/Design System PRs.
How?
Added entries to
LABEL_FEATURE_MAPPINGinbin/plugin/commands/changelog.js:[Tool] ESLint plugin→ Tools (type mapping)[Package] DataViews→ DataViews[Package] Core Data→ Data LayerConnectors screen→ Connectors[Package] UI→ Components[Package] Compose→ Components[Package] Theme→ ComponentsDesign System→ ComponentsTesting Instructions
npm run other:changelog -- --milestone="Gutenberg 22.8"Use of AI Tools
Claude Code was used to assist with identifying uncategorized PRs, recommending label mappings, and drafting this PR.