UI: Update @base-ui/react from 1.2.0 to 1.3.0#76603
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +507 B (+0.01%) Total Size: 8.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 44685bc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23217597565
|
ciampo
approved these changes
Mar 18, 2026
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
LGTM 🚀 with two caveats:
- I agree with flagging the new warning for the render prop, which should be fixed in the next release anyway
- As a follow-up, we should evaluate the new
Labelpart for theSelectcomponent (mui/base-ui#4167)
adamsilverstein
pushed a commit
that referenced
this pull request
Mar 31, 2026
* Update @base-ui/react from 1.2.0 to 1.3.0 * Add changelog Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]>
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
* Update @base-ui/react from 1.2.0 to 1.3.0 * Add changelog Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]>
ciampo
added a commit
that referenced
this pull request
Apr 14, 2026
The render function example used `defaultRender` (the workaround name from #76603). Now that the code uses `DEFAULT_RENDER` again, update the documentation to match. Made-with: Cursor
ciampo
added a commit
that referenced
this pull request
Apr 14, 2026
* Update @base-ui/react from 1.3.0 to 1.4.0 Made-with: Cursor * Revert render prop workaround now fixed upstream Base UI 1.4.0 includes a fix for mui/base-ui#4361, which narrows the render prop warning to no longer false-positive on screaming snake case constants like `DEFAULT_RENDER`. The `textareaRender` rename (from `Render`) is kept because PascalCase names are still warned about, as intended. Made-with: Cursor * Fix TypeScript errors from Base UI 1.4.0 style prop change Base UI 1.4.0 added a state-callback form to the `style` prop (mirroring what `className` already had). This caused type mismatches where our wrapper components forward `style` to elements that only accept plain `CSSProperties`. - `ComponentProps`: strip and redefine `style` as plain `CSSProperties`, consistent with how `className` is already handled - `SelectPopupProps`: override `style` since it's forwarded to the Positioner (different state type than Popup) Made-with: Cursor * Update CONTRIBUTING.md example to match reverted naming The render function example used `defaultRender` (the workaround name from #76603). Now that the code uses `DEFAULT_RENDER` again, update the documentation to match. Made-with: Cursor * Strip style callback from SelectTrigger and SelectItem types SelectTriggerProps and SelectItemProps extend Base UI props directly (not through ComponentProps), so they were leaking the new style callback form from 1.4.0. Strip it for consistency with how ComponentProps handles style across all other components. Made-with: Cursor * Address PR feedback: update JSDoc wording, refactor Select types to ComponentProps Update className/style JSDoc in ComponentProps to say "element" instead of "component". Refactor SelectTriggerProps, SelectPopupProps, and SelectItemProps to use ComponentProps instead of manually omitting and re-adding style — consistent with the pattern used by Tabs and Fieldset. Made-with: Cursor --- Co-authored-by: ciampo <[email protected]> Co-authored-by: mirka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates
@base-ui/reactfrom 1.2.0 to 1.3.0 in@wordpress/ui.Why?
v1.3.0 (Mar 12, 2026) includes bug fixes for components we use (Autocomplete, Combobox, Select, Tabs, Tooltip, Field, ScrollArea, among others).
How?
DEFAULT_RENDERconstant todefaultRenderin Field, and theRenderinner function totextareaRenderin Textarea. Base UI 1.3 now warns when therenderprop receives a function whose name starts with an uppercase letter, interpreting it as a mistakenly passed component. This is a workaround — an upstream issue has been filed since the warning doesn't apply to our usage (we're passing render functions, not components).getAnimationspolyfill to global test mocks. Base UI's ScrollArea now callsElement.getAnimations(), which jsdom doesn't implement.Testing Instructions
TypeScript, build, and unit tests pass.
Use of AI Tools
Cursor was used for initial research and drafting.