Add isNavigationPostEditorKey symbol to fix menu display context#76461
Merged
Add isNavigationPostEditorKey symbol to fix menu display context#76461
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
github-actions
bot
added
[Package] Editor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
added
[Type] Bug
|
Size Change: +13 B (0%) Total Size: 8.75 MB
ℹ️ View Unchanged
|
scruffian
reviewed
Mar 12, 2026
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
Tested the template part isolated editor ✅
Tested the navigation isolated editor ✅
|
Flaky tests detected in b063a70. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23012989644
|
scruffian
approved these changes
Mar 12, 2026
Contributor
|
Thanks for fixing this so quickly 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #76439
When editing a template part that contains a navigation block (e.g. a header with
focusMode=true), the navigation block's responsive overlay/hamburger menu was incorrectly suppressed — the same as when editing a navigation post directly.Why?
The
editorDisabledResponsiveflag relied onisIsolatedEditorKey, which istruefor any isolated editor context:wp_template_part,wp_block, andwp_navigation. Only thewp_navigationcase should disable responsive mode (so the full menu is always visible when editing a nav entity directly).How?
Adds a new private block-editor setting key
isNavigationPostEditorKey, set totrueonly whenpostType === 'wp_navigation'inuse-block-editor-settings. The navigation block uses this narrower key instead ofisIsolatedEditorKey.Also removes an unrelated
isPreviewModecondition from the same check, as it was not needed.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2026-03-12.at.11.40.10.AM.mov