Theme: Add no-token-fallback-values stylelint rule#76415
Merged
Conversation
|
Size Change: 0 B Total Size: 8.75 MB ℹ️ View Unchanged
|
mirka
force-pushed
the
add/no-token-fallback-values-stylelint-rule
branch
from
168179d to
94a858c
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 74ec5ce. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23209966517
|
ciampo
approved these changes
Mar 17, 2026
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
Nice refactor! LGTM 🚀
Enabled in the root .stylelintrc.js only (not in @wordpress/stylelint-config) to avoid imposing it on external consumers of the preset.
Makes sense, as far as the new rule is easy to discover?
packages/theme/src/stylelint-plugins/test/fixtures/no-token-fallback-values-valid.css
Show resolved
Hide resolved
packages/theme/src/stylelint-plugins/test/fixtures/no-token-fallback-values-invalid.css
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a new stylelint rule
plugin-wpds/no-token-fallback-valuesthat disallows manually authored fallback values for--wpds-*design tokens.Why?
The
addFallbackToVarPostCSS plugin in@wordpress/themealready injects fallbacks for--wpds-*tokens at build time. Manual fallbacks in source are redundant and can drift out of sync with the token definitions.This is a companion rule to that build plugin, similar to how
no-unknown-ds-tokensvalidates that tokens exist andno-setting-wpds-custom-propertiesprevents defining tokens outside of the design system.How?
packages/theme/src/stylelint-plugins/no-token-fallback-values.mjs. Uses a regex to matchvar(--wpds-<name>,patterns (the comma indicates a fallback)..stylelintrc.jsonly (not in@wordpress/stylelint-config) to avoid imposing it on external consumers of the preset.Testing Instructions
npm run test:unit -- --testPathPattern="packages/theme/src/stylelint-plugins/test"— all 15 tests across the 3 rules should pass.