Connectors: Add connectors registry for extensibility#76364
Conversation
|
Flaky tests detected in d54af13. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22946168903
|
Ports the connectors registry from WordPress core (wordpress-develop#11175) to Gutenberg. Introduces WP_Connector_Registry class and wp_connectors_init action hook so plugins can register their own connectors alongside the built-in defaults (Anthropic, Google, OpenAI). Co-Authored-By: Claude Opus 4.6 <[email protected]>
…_get_connectors Uses function_exists guards so plugins can use the wp_* names now and seamlessly switch to core's implementation once WordPress 7.0 ships. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Move WP_Connector_Registry class and wp_* helper functions to lib/compat/wordpress-7.0/ where other core polyfills live. This aligns with the existing PHPCS exclude pattern for the default text domain and keeps core-ported code in the standard location. Co-Authored-By: Claude Opus 4.6 <[email protected]>
6aa9067 to
462a198
Compare
Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Extend WP_Connector_Registry to persist logo_url, removing the need for a separate enrichment step. Resolve logo URLs from AI Client metadata alongside name and description in _gutenberg_connectors_init. Co-Authored-By: Claude Opus 4.6 <[email protected]>
… core Move the logo URL resolver to lib/compat/wordpress-7.0/connectors.php as a polyfill for the _wp_connectors_resolve_ai_provider_logo_url function being added to WP core. Remove the Gutenberg-prefixed version and its unit tests, which will be covered by core. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
The latest commit polyfills |
|
|
||
| $name = $provider_metadata->getName(); | ||
| $description = $provider_metadata->getDescription(); | ||
| $logo_url = method_exists( $provider_metadata, 'getLogoPath' ) && $provider_metadata->getLogoPath() |
There was a problem hiding this comment.
Ideally we should remove the method_exists check soon. At least in Core it should be removed as soon as that new php-ai-client version update has been committed.
There was a problem hiding this comment.
Yes. We need to commit PHP AI client update first.
* Connectors: Add connectors registry for extensibility Ports the connectors registry from WordPress core (wordpress-develop#11175) to Gutenberg. Introduces WP_Connector_Registry class and wp_connectors_init action hook so plugins can register their own connectors alongside the built-in defaults (Anthropic, Google, OpenAI). Co-Authored-By: Claude Opus 4.6 <[email protected]> * Connectors: Polyfill wp_is_connector_registered, wp_get_connector, wp_get_connectors Uses function_exists guards so plugins can use the wp_* names now and seamlessly switch to core's implementation once WordPress 7.0 ships. Co-Authored-By: Claude Opus 4.6 <[email protected]> * Connectors: Move core polyfills to lib/compat/wordpress-7.0 Move WP_Connector_Registry class and wp_* helper functions to lib/compat/wordpress-7.0/ where other core polyfills live. This aligns with the existing PHPCS exclude pattern for the default text domain and keeps core-ported code in the standard location. Co-Authored-By: Claude Opus 4.6 <[email protected]> * Connectors: Add backport changelog entry for wordpress-develop#11175 Co-Authored-By: Claude Opus 4.6 <[email protected]> * Connectors: Add logo_url support to registry and resolve during init Extend WP_Connector_Registry to persist logo_url, removing the need for a separate enrichment step. Resolve logo URLs from AI Client metadata alongside name and description in _gutenberg_connectors_init. Co-Authored-By: Claude Opus 4.6 <[email protected]> * Connectors: Polyfill _wp_connectors_resolve_ai_provider_logo_url from core Move the logo URL resolver to lib/compat/wordpress-7.0/connectors.php as a polyfill for the _wp_connectors_resolve_ai_provider_logo_url function being added to WP core. Remove the Gutenberg-prefixed version and its unit tests, which will be covered by core. Co-Authored-By: Claude Opus 4.6 <[email protected]> --------- Co-authored-by: Claude Opus 4.6 <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: felixarntz <[email protected]>
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 53ebecf |
This updates the pinned hash from the `gutenberg` from `9b8144036fa5faf75de43d4502ff9809fcf689ad` to `8c78d87453509661a9f28f978ba2c242d515563b`. The following changes are included: - Navigation Editor: Allow any blocks to be inserted by gating contentOnly insertion rules to section blocks (WordPress/gutenberg#76189) - Add `fetchpriority=low` to `IMG` tags in collapsed Details blocks (WordPress/gutenberg#76269) - Connectors: Add logo URL support for custom AI providers (WordPress/gutenberg#76190) - Cover Block: Add a playlist parameter to loop YouTube background videos. (WordPress/gutenberg#76004) - Connectors: Memoize getConnectors selector (WordPress/gutenberg#76339) - HTML Block: Fix broken layout (WordPress/gutenberg#76278) - Tests: Skip connector logo URL tests when AI Client is unavailable (WordPress/gutenberg#76343) - Navigation Overlay: Explicitly set fetchpriority for images (WordPress/gutenberg#76208) - Connectors: Show API key source for env vars and wp-config constants (WordPress/gutenberg#76355) - Connectors: Move API key validation and masking to REST dispatch level (WordPress/gutenberg#76327) - Connectors: Replace apiFetch with core-data store selectors (WordPress/gutenberg#76333) - Do not sync local attributes (WordPress/gutenberg#76267) - Add `fetchpriority=low` to `IMG` tags in collapsed Accordion Item blocks (WordPress/gutenberg#76336) - Implement disconnection debounce after initial connection (WordPress/gutenberg#76114) - Allow Post Content to be edited when 'Show template' is active and Post content is nested in a Template Part (WordPress/gutenberg#76305) - Fix: Document Bar: Back button flickers (WordPress/gutenberg#76320) - RTC: Move event hooks from editor to core-data (WordPress/gutenberg#76358) - fix(navigation): prevent right-justified submenu overflow in custom overlays (WordPress/gutenberg#76360) - Connectors: Add connectors registry for extensibility (WordPress/gutenberg#76364) - Connectors: Add empty state when no connectors are registered (WordPress/gutenberg#76375) - Temp: Disable RTC in the site editor (WordPress/gutenberg#76223) - Connectors: Add AI Experiments plugin callout with install/activate functionality (WordPress/gutenberg#76379) - Editor: Polish real-time collaboration presence UI and move Avatar to editor package (WordPress/gutenberg#75652) (WordPress/gutenberg#76365) - RTC: Add collaborator selection highlighting in rich text (WordPress/gutenberg#76107) - Sync changes from `wp_enqueue_global_styles()` to Gutenberg override (WordPress/gutenberg#76127) - [RTC] Fix performance regression on post save (WordPress/gutenberg#76370) - Media: Enable AVIF support for client-side uploads (WordPress/gutenberg#76371) - Connectors: Move plugin status computation to script module data (WordPress/gutenberg#76409) - Revisions: Skip rendered fields in REST API responses (WordPress/gutenberg#76347) - E2E Tests: Add connector setup flow tests with test AI provider (WordPress/gutenberg#76433) - RTC: Place sync connection modal in front of popover (WordPress/gutenberg#76431) - Connectors: Sync PHP code with WordPress Core (WordPress/gutenberg#76443) - Editor: Show own presence in collaborative editing sessions (WordPress/gutenberg#76413) (WordPress/gutenberg#76445) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/9b8144036fa5faf75de43d4502ff9809fcf689ad…8c78d87453509661a9f28f978ba2c242d515563b. Log created with: git log --reverse --format="- %s" 9b8144036fa5faf75de43d4502ff9809fcf689ad..8c78d87453509661a9f28f978ba2c242d515563b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. git-svn-id: https://develop.svn.wordpress.org/trunk@61988 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `9b8144036fa5faf75de43d4502ff9809fcf689ad` to `8c78d87453509661a9f28f978ba2c242d515563b`. The following changes are included: - Navigation Editor: Allow any blocks to be inserted by gating contentOnly insertion rules to section blocks (WordPress/gutenberg#76189) - Add `fetchpriority=low` to `IMG` tags in collapsed Details blocks (WordPress/gutenberg#76269) - Connectors: Add logo URL support for custom AI providers (WordPress/gutenberg#76190) - Cover Block: Add a playlist parameter to loop YouTube background videos. (WordPress/gutenberg#76004) - Connectors: Memoize getConnectors selector (WordPress/gutenberg#76339) - HTML Block: Fix broken layout (WordPress/gutenberg#76278) - Tests: Skip connector logo URL tests when AI Client is unavailable (WordPress/gutenberg#76343) - Navigation Overlay: Explicitly set fetchpriority for images (WordPress/gutenberg#76208) - Connectors: Show API key source for env vars and wp-config constants (WordPress/gutenberg#76355) - Connectors: Move API key validation and masking to REST dispatch level (WordPress/gutenberg#76327) - Connectors: Replace apiFetch with core-data store selectors (WordPress/gutenberg#76333) - Do not sync local attributes (WordPress/gutenberg#76267) - Add `fetchpriority=low` to `IMG` tags in collapsed Accordion Item blocks (WordPress/gutenberg#76336) - Implement disconnection debounce after initial connection (WordPress/gutenberg#76114) - Allow Post Content to be edited when 'Show template' is active and Post content is nested in a Template Part (WordPress/gutenberg#76305) - Fix: Document Bar: Back button flickers (WordPress/gutenberg#76320) - RTC: Move event hooks from editor to core-data (WordPress/gutenberg#76358) - fix(navigation): prevent right-justified submenu overflow in custom overlays (WordPress/gutenberg#76360) - Connectors: Add connectors registry for extensibility (WordPress/gutenberg#76364) - Connectors: Add empty state when no connectors are registered (WordPress/gutenberg#76375) - Temp: Disable RTC in the site editor (WordPress/gutenberg#76223) - Connectors: Add AI Experiments plugin callout with install/activate functionality (WordPress/gutenberg#76379) - Editor: Polish real-time collaboration presence UI and move Avatar to editor package (WordPress/gutenberg#75652) (WordPress/gutenberg#76365) - RTC: Add collaborator selection highlighting in rich text (WordPress/gutenberg#76107) - Sync changes from `wp_enqueue_global_styles()` to Gutenberg override (WordPress/gutenberg#76127) - [RTC] Fix performance regression on post save (WordPress/gutenberg#76370) - Media: Enable AVIF support for client-side uploads (WordPress/gutenberg#76371) - Connectors: Move plugin status computation to script module data (WordPress/gutenberg#76409) - Revisions: Skip rendered fields in REST API responses (WordPress/gutenberg#76347) - E2E Tests: Add connector setup flow tests with test AI provider (WordPress/gutenberg#76433) - RTC: Place sync connection modal in front of popover (WordPress/gutenberg#76431) - Connectors: Sync PHP code with WordPress Core (WordPress/gutenberg#76443) - Editor: Show own presence in collaborative editing sessions (WordPress/gutenberg#76413) (WordPress/gutenberg#76445) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/9b8144036fa5faf75de43d4502ff9809fcf689ad…8c78d87453509661a9f28f978ba2c242d515563b. Log created with: git log --reverse --format="- %s" 9b8144036fa5faf75de43d4502ff9809fcf689ad..8c78d87453509661a9f28f978ba2c242d515563b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. Built from https://develop.svn.wordpress.org/trunk@61988 git-svn-id: http://core.svn.wordpress.org/trunk@61270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Summary
Ports the connectors registry from WordPress core (wordpress-develop#11175) to Gutenberg.
WP_Connector_Registryclass (singleton) inlib/compat/wordpress-7.0/managing connector registration with validation for IDs, required fields, and authentication methodsfunction_existsguards:wp_is_connector_registered(),wp_get_connector(),wp_get_connectors()_wp_connectors_resolve_ai_provider_logo_url()to convert plugin file paths to URLs for provider logos_gutenberg_connectors_init()that creates the registry, registers built-in connectors (merged with AI Client data), and fireswp_connectors_initaction for plugin extensibility_gutenberg_get_connector_settings()to build onwp_get_connectors()and enrich with logo URLs and plugin statuslib/compat/wordpress-7.0/following the standard pattern, withclass_exists/function_existsguards to avoid double declarationsTest plan
wp_is_connector_registered(),wp_get_connector(),wp_get_connectors()return expected datawp_connectors_initaction fires and allows plugins to register custom connectorsWP_Connector_Registry::set_instance()outsideinittriggers_doing_it_wrong🤖 Generated with Claude Code