Storybook: Rename "Components (Deprecated)" to "Deprecated"#76362
Storybook: Rename "Components (Deprecated)" to "Deprecated"#76362
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jasmussen! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
I like that better, actually. I'll take a look. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected]. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 6.89 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 99ee379. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22957721915
|
|
@jasmussen, you can't seem to escape the "First-time Contributor" label 😄 P.S. I like the new label. |
Indeed. Part of this is perhaps a recent laptop switch. The most recent thing I've tried is disconnecting and reconnecting GH to WP.org, we'll see if the label is gone on new PRs. For now I'll live with the curse.
Thanks. Do you prefer a single top level deprecated one? Or subfolders like Marco proposed? |
|
I personally like the single top-level, as it's easy to scan what's deprecated. But subfolders give it a better structure. I guess the final decision depends on how we want to structure the Storybook. |
|
I feel like it's worth making a decision on in this PR, so I'd love thoughts by @ciampo before we land this, because either way, permalinks will change, which is something we should ideally minimise. I don't feel strongly, but if I had to choose, I'd prefer the subfolders idea rather than the top level folder, mostly to focus on what you should use rather than what you shouldn't. |
|
+1 to subfolders. It's probably helpful to understand which package the component was deprecated from, and a top level 'Deprecated' item feels too prominent. |
mirka
left a comment
There was a problem hiding this comment.
I agree that subfolders are fine here. Also don't worry about the permalinks. We already put explicit id fields in there when we moved them to the Deprecated folder, and that keeps the URLs stable.
Went ahead and pushed the changes, as well as a sort order tweak to keep the Deprecated subfolder at the bottom of the subfolders.
|
Fantastic, thanks so much! I'll also merge this one when the checks pass. |

What?
Renames "Components (Deprecated)" to "Deprecated" in Storybook. Before:
After:
Might pair well with #76361.
Why?
This change is mainly a taxonomical one, to simplify the scannability of the sidebar. A side effect is that it can contain information about deprecations that isn't just components. I'd like to think we don't deprecate often, but as 76361 also delves into, Storybook isn't just about component docs.
Testing Instructions
npm run storybook:dev