Core Data: Fix 'canUser' returning 'undefined' when the allow header is missing#76307
Merged
Core Data: Fix 'canUser' returning 'undefined' when the allow header is missing#76307
Conversation
Mamaduka
added
[Type] Bug
|
Size Change: +3 B (0%) Total Size: 6.89 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ce8cc60. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22845993662
|
youknowriad
approved these changes
Mar 9, 2026
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
The change makes sense to me. Curious though did you see actual issues as a result of this?
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
Nothing that could potentially break things, but here was thinking:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Cast permission values to boolean in
getUserPermissionsFromAllowHeadersocanUserreturnsfalseinstead ofundefinedwhen the response has no allow header. e.g., React Native, or more restrictive APIs.Why?
I noticed this while experimenting with the Plugins endpoint and testing with low-cap users.
Testing Instructions
The fix and resolve has good unit test coverage.