Extensible Site Editor: Make canvas previews full height#76201
Merged
Conversation
jeryj
added
[Type] Experimental
|
Size Change: +29 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
scruffian
approved these changes
Mar 5, 2026
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
Thanks for working on this. LGTM. A few things I noticed that aren't blockers...
- For the Spinner state we use
height: 100vhnotmin-height, so we might want to standardise around that - In the Site Editor v2, the navigation collapses to a hamburger. We should fix this in a different PR though!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in bfa91fe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22730040051
|
youknowriad
reviewed
Mar 5, 2026
| styles: [ | ||
| ...( editorSettings.styles ?? [] ), | ||
| ...( settings?.isPreviewMode | ||
| ? [ { css: 'body{min-height:100vh;}' } ] |
Contributor
There was a problem hiding this comment.
I'm not sure this is a "lazy-editor" concern. Why would the lazy-editor be full height by default? How is this solved in other places?
Contributor
There was a problem hiding this comment.
I see that it's based on canvas mode, why didn't we do the same here (I guess in "boot" package)
Contributor
Author
There was a problem hiding this comment.
Ah, I see what you mean. Looking at it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #75741
What?
Fixes the navigation being stuck to the top of the page in the preview canvas instead of centered.
Why?
UX
How?
The current site editor adds height: 100vh when the canvas is in "view" mode. The Extensible Site Editor doesn't include this, which causes the navigation preview to be stuck to the top of the page instead of centered.
I added a 100vh height to the Extensible Site Editor version of the canvas as well. I did not bring the pointer style over, as it doesn't seem needed since there's a full size button covering the canvas preview which has the pointer hand.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast