Content Guidelines: Add block guidelines management by aswasif007 · Pull Request #76187 · WordPress/gutenberg

aswasif007 · 2026-03-05T08:43:19Z

What?

Related issue: #75260

Adds a new Blocks section to the Content Guidelines page, allowing administrators to define and manage tailored guidelines for specific block types.

Why?

The Content Guidelines feature currently supports site-wide categories (Site, Copy, Images, Additional), but has no way to express guidelines scoped to a particular block type. This is useful for teams who want to constrain or document how specific blocks should be used — for example, requiring alt text on image blocks or restricting heading hierarchy.

How?

Added a new blocks category to the guidelines data model and REST payload. Each entry maps a block name (e.g. core/image) to a guidelines string.
Added fetchBlockTypes() in api.ts to load all registered top-level block types via /wp/v2/block-types and store them as searchable options.
Added a BlockGuidelines component that renders a DataViews list of all configured block guidelines, with each row showing the block's icon, name, and guideline text. Row-level Edit and Delete actions are available.
Added a BlockGuidelineModal component for adding or editing a block guideline. It uses a ComboboxControl to search and select a block, and a TextareaControl for the guideline content. The modal title and submit label adapt between add and edit modes.
Added blockIconMap in utils.tsx — a mapping of core block names to their @wordpress/icons equivalents, used for visual display in the list.
Extended the Redux store with new blocks state, SET_BLOCK_GUIDELINE / SET_BLOCK_TYPES actions, and getBlockGuideline / getBlockGuidelines / getBlockTypes selectors.

Testing Instructions

Navigate to the Content Guidelines admin page.
Open the Blocks accordion section.
Click Add guideline — the modal should open.
Search for a block (e.g. "Image") using the combobox and enter some guideline text.
Click Add guideline — the modal should close and the new entry should appear in the list.
Click the Edit action on an existing row — the modal should reopen pre-filled with the block and its guideline text. Update the text and save; verify the list reflects the change.
Click the Delete action on a row and confirm the entry is removed.
Reload the page and verify all saved guidelines persist.

Testing Instructions for Keyboard

Tab to the Blocks accordion header and press Enter to expand it.
Tab to the Add guideline button and press Enter to open the modal.
Tab to the block combobox, type to search, and use arrow keys to select a block.
Tab to the guideline textarea and type content.
Tab to the Add guideline submit button and press Enter to save.
Verify focus returns appropriately after the modal closes.

Screenshots

github-actions · 2026-03-05T08:43:29Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aswasif007 <[email protected]>
Co-authored-by: andrewserong <[email protected]>
Co-authored-by: ramonjd <[email protected]>
Co-authored-by: saroshaga <[email protected]>
Co-authored-by: aagam-shah <[email protected]>
Co-authored-by: fditrapani <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

routes/content-guidelines/utils.tsx

routes/content-guidelines/api.ts

routes/content-guidelines/components/block-guidelines.tsx

routes/content-guidelines/components/block-guideline-modal.scss

saroshaga · 2026-03-06T11:24:08Z

routes/content-guidelines/api.ts

 				guidelines: categories.additional,
 			},
+			blocks: Object.fromEntries(
+				Object.entries( blockGuidelines ).map(


nit: Both the remove action in block-guidelines.tsx:110 and block-guideline-modal.tsx:87 use setBlockGuideline(blockName, '') to represent deletion. But I think blocks would still be sent as { "core/image": { "guidelines": "" } } rather than being omitted. This does not happen in practise because we disable the button when the textarea is empty. But wondering if the reducer should filter out empty-string entries, or saveContentGuidelines should exclude them before sending.

Addressed here

Had to revert ^ because it breaks the block-guideline deletion. Basically in the backend if we see that a block's guideline is empty string, we remove the guideline from meta. So we have to send empty string.

Here is the relevant code:

gutenberg/lib/experimental/content-guidelines/class-gutenberg-content-guidelines-rest-controller.php

Lines 401 to 413 in 8b4fd02

// Handle block-specific guidelines as individual meta keys.

if ( isset( $categories['blocks'] ) && is_array( $categories['blocks'] ) ) {

foreach ( $categories['blocks'] as $block_name => $block_data ) {

$meta_key = Gutenberg_Content_Guidelines_Post_Type::block_name_to_meta_key( $block_name );

$value = isset( $block_data['guidelines'] ) ? $block_data['guidelines'] : '';

if ( ! empty( $value ) ) {

update_post_meta( $post_id, $meta_key, $value );

} else {

delete_post_meta( $post_id, $meta_key );

}

}

}

routes/content-guidelines/stage.tsx

routes/content-guidelines/components/block-guidelines.tsx

saroshaga · 2026-03-06T11:39:32Z

routes/content-guidelines/store.ts

+	getGuideline(
+		state: ContentGuidelinesState,
+		category: string
+	): string | Record< string, string > {


Claude suggested here to use the discriminated return type / separate selector.

..by keeping getGuideline returning string only, since there's already getBlockGuidelines() and getBlockGuideline(blockName) for block lookups. Just guard against the blocks key:

getGuideline(state: ContentGuidelinesState, category: string): string { if (category === 'blocks') { return ''; // callers should use getBlockGuideline(blockName) instead } return (state.categories[category] as string) ?? ''; }

Or even better, type category more narrowly so TypeScript enforces it at compile time:

type TextCategory = 'site' | 'copy' | 'images' | 'additional'; getGuideline(state: ContentGuidelinesState, category: TextCategory): string { return state.categories[category] ?? ''; }

That way if someone writes getGuideline('blocks'), TypeScript rejects it and points them to getBlockGuideline() / getBlockGuidelines() instead. No union return type, no as string casts at call sites, and the two data shapes stay cleanly separated.

The TextCategory type could live in types.ts alongside the existing Categories interface, keeping it DRY if other selectors/actions need the same constraint.

@aswasif007 : perhaps this is superseded with @aagam-shah 's suggestion below: #76187 (comment) .

saroshaga · 2026-03-06T11:49:55Z

routes/content-guidelines/store.ts

 };

-const CATEGORIES = [ 'site', 'copy', 'images', 'additional' ];
+const CATEGORIES = [ 'site', 'copy', 'images', 'additional', 'blocks' ];


This is more of a note for future reference than feedback that needs addressing.

When I first started to design this, I wanted to keep two clear category types: primitive and complex (like blocks). This is also to avoid having to hardcode categories like we've done here.

Here's a rough sketch of it could look like:

1. Types — define the two classes:

// types.ts interface PrimitiveCategory { kind: 'primitive'; slug: string; title: string; description: string; } interface ComplexCategory { kind: 'complex'; slug: string; title: string; description: string; component: React.ComponentType; // custom renderer } type GuidelineCategory = PrimitiveCategory | ComplexCategory;

2. Registry — declare categories with their class:

// stage.tsx const GUIDELINE_CATEGORIES: GuidelineCategory[] = [ { kind: 'primitive', slug: 'site', title: __('Site'), description: __("Describe your site's purpose...") }, { kind: 'primitive', slug: 'copy', title: __('Copy'), description: __('Set your writing standards...') }, { kind: 'primitive', slug: 'images', title: __('Images'), description: __('Outline your style...') }, { kind: 'complex', slug: 'blocks', title: __('Blocks'), description: __('Create tailored guidelines...'), component: BlockGuidelines }, { kind: 'primitive', slug: 'additional', title: __('Additional'), description: __('Add additional guidelines...') }, ];

3. Rendering — dispatch on kind, no slug checks:

{GUIDELINE_CATEGORIES.map((item) => ( <li key={item.slug}> <GuidelineAccordion title={item.title} description={item.description} ...> {item.kind === 'primitive' ? ( <GuidelineAccordionForm slug={item.slug} ... /> ) : ( <item.component /> )} </GuidelineAccordion> </li> ))}

The ternary still exists, but it's generic — it dispatches on kind, not on a specific slug. Adding a future complex category (say, "media" with its own custom UI) is just one more entry in the array with kind: 'complex' and a component.

4. State — separate storage by kind:

// types.ts export interface ContentGuidelinesState { id: number | null; status: string | null; primitives: Record<string, string>; // site, copy, images, additional complex: Record<string, Record<string, string>>; // blocks, future ones... }

5. Store parsing — loop by kind, no special-case branches:

const PRIMITIVE_SLUGS = GUIDELINE_CATEGORIES .filter(c => c.kind === 'primitive') .map(c => c.slug); const COMPLEX_SLUGS = GUIDELINE_CATEGORIES .filter(c => c.kind === 'complex') .map(c => c.slug); function parseResponse(response: RestGuidelinesResponse) { const cats = response.guideline_categories ?? {}; const primitives: Record<string, string> = {}; for (const slug of PRIMITIVE_SLUGS) { primitives[slug] = cats[slug]?.guidelines ?? ''; } const complex: Record<string, Record<string, string>> = {}; for (const slug of COMPLEX_SLUGS) { complex[slug] = {}; const entries = cats[slug] ?? {}; for (const key in entries) { complex[slug][key] = entries[key]?.guidelines ?? ''; } } return { id: response.id ?? null, status: response.status ?? null, primitives, complex }; }

6. Selectors — one per kind class, not per category:

// Primitive categories getGuideline(state, slug: string): string { return state.primitives[slug] ?? ''; }, // Complex categories (blocks today, anything tomorrow) getComplexGuidelines(state, slug: string): Record<string, string> { return state.complex[slug] ?? {}; }, getComplexGuideline(state, slug: string, key: string): string { return state.complex[slug]?.[key] ?? ''; },

This will obviously introduce abstraction that we don't need today. So we shouldn't do it right now.

+1 to this direction — the full registry pattern with kind discriminant is the right end state.

To keep things simple for now, could we start with just the type foundation? It fixes the immediate mixed Categories type issue without introducing the registry abstraction yet:

// types.ts — REST layer types that match the actual PHP response shapes interface BaseGuideline { guidelines?: string; } interface PrimitiveGuideline extends BaseGuideline { label?: string; } type AdvancedGuideline = Record< string, BaseGuideline >; interface RestGuidelineCategories { site?: PrimitiveGuideline; copy?: PrimitiveGuideline; images?: PrimitiveGuideline; additional?: PrimitiveGuideline; blocks?: AdvancedGuideline; } interface RestGuidelinesResponse { id: number; status: string; guideline_categories?: RestGuidelineCategories; } // Store state — two flat maps, no mixed union interface ContentGuidelinesState { id: number | null; status: string | null; categories: Record< string, string >; // primitive: slug -> text blockGuidelines: Record< string, string >; // advanced: blockName -> text }

getGuideline() stays string-only, blocks get their own path via getBlockGuideline(name), and the REST types self-document the actual API shapes. When the full registry pattern is needed later, the REST types carry forward unchanged — only the store state evolves.

@aagam-shah : let's take up your suggestion in a follow-up PR 👍

routes/content-guidelines/components/block-guideline-modal.tsx

fditrapani · 2026-03-06T18:32:42Z

Nice work @aswasif007. This is a solid start! Here's what I found:

Block list spacing
Once we have a block list, the alignment of the elements is thrown off because the table is inset:

Ideally we can use some custom styles to achieve this:

Data views controls
The data views controls feel unnecessary when we have few items. Any chance we can hide those until we have more than 7 items? The filters are also not particularly helpful. Perhaps we can hide those indefinitely.

Adding block guidelines

After you add a block guideline, can we exclude it from the list? The adding > edit behaviour was unexpected and really subtle:

Removing guidelines

I mocked up some notices around removing guidlines in Figma. What do you think about adding those now or would you prefer to do that separately?

Transition
This is unrelated to this PR but wanted to raise it here since we're looking at this together. Feel free to tackle it separately. I noticed a weird flicker when I first visit the content guidelines page. Is there anything we can do to prevent that?

Screen.Recording.2026-03-06.at.1.21.48.PM.mov

routes/content-guidelines/components/block-guidelines.tsx

ramonjd · 2026-03-09T05:38:54Z

Maybe one for @fditrapani I mentioned it over in the previous PR, but I think it'd be helpful to do some simple validation in a follow up.

Or, if it's expected that users "clear" entries then provide a dedicated "Reset/Clear/Remove" button.

Kapture.2026-03-09.at.16.33.00.mp4

Also this point:

i'd be interested to hear from design folks, but maybe validation could be centralized via a single save button. that might also mitigate multiple, simultaneous submissions given there are 4 x submit buttons

All can be follow ups.

saroshaga · 2026-03-09T06:21:37Z

Or, if it's expected that users "clear" entries then provide a dedicated "Reset/Clear/Remove" button.

Filippo has shared designs for this which will be taken up in future PRs
@ramonjd

And omit dataviews search too when there are less than 6 items

Also, use textcontrol instead of combobox in edit mode

saroshaga

I left one small suggestion but I think it looks good to do! Thank you for working through all the feedback!

saroshaga · 2026-03-09T10:40:25Z

routes/content-guidelines/components/block-guideline-modal.tsx

+						</Notice.Title>
+					</Notice.Root>
+				) }
+				<HStack


minor: can the cursor be styled as pointer only for the submenu ... button?

The entire bar need not have a pointer cursor.

(doesn't show up in the screenshot)

I'm seeing the pointer on mine. I forgot to mention this in my feedback but if you click the row/title, can we open the Edit guideline modal?

Sarosh is referring to the cursor when submenu is open.

I am afraid this needs to be fixed in the DataView component. I think for such modifications in Gutenberg, we are supposed to create a github-issue in the repository first.

if you click the row/title, can we open the Edit guideline modal?

Addressed here: c1af24a

Wasif, I could also see the cursor when the submenu was closed but it was a pointer . Since the bar is not clickable, there's no use for the pointer style over that portion.

fditrapani · 2026-03-09T13:47:22Z

Plus one on the great work for the updates. I spotted something minor, if you remove the guideline from the table, we show the modal confirmation.

We don't show it if you press remove from the edit modal:

aswasif007 · 2026-03-10T00:45:04Z

@fditrapani regarding

if you remove the guideline from the table, we show the modal confirmation. We don't show it if you press remove from the edit modal.

Should we show the confirmation modal on top of the edit modal? Or replace the edit modal with the confirmation modal?

Since this PR is already approved, I will add it in a separate PR so that we are free to roll this one out.

routes/content-guidelines/components/block-guideline-modal.tsx

routes/content-guidelines/components/block-guidelines.tsx

routes/content-guidelines/stage.tsx

andrewserong

Functionality-wise this is testing pretty well for me! Just left a few comments, mostly for code quality things that would be good to fix up (either now or in a follow-up). The main one is that to match the PHP backend logic, it looks the list of blocks should probably be filtered?

Nice progress here!

ramonjd

Thanks again @aswasif007

Like @andrewserong I left only comments to keep in mind for follow ups.

I think the createSuccessNotice translation should be fixed in this PR though. Once that's done we can merge so folks can concentrate on the follow ups.

routes/content-guidelines/components/block-guideline-modal.tsx

ramonjd · 2026-03-10T01:36:05Z

routes/content-guidelines/store.ts

+	getGuideline(
+		state: ContentGuidelinesState,
+		category: string
+	): string | Record< string, string > {
+		return state.categories[ category ];
 	},
-	getAllGuidelines(
-		state: ContentGuidelinesState
-	): Partial< Record< string, string > > {
+	getAllGuidelines( state: ContentGuidelinesState ): Categories {
 		return state.categories;
 	},
+	getBlockGuidelines(
+		state: ContentGuidelinesState
+	): Record< string, string > {
+		return state.categories.blocks;
+	},
+	getBlockGuideline(
+		state: ContentGuidelinesState,
+		blockName: string
+	): string {
+		return state.categories.blocks[ blockName ] ?? '';
+	},


Just a reminder that it might be wise to add test coverage in follow ups to guard against bugs/regressions.

👍🏻

routes/content-guidelines/store.ts

ramonjd · 2026-03-10T01:45:23Z

routes/content-guidelines/components/block-guideline-modal.scss

+	.components-modal__header-heading {
+		font-weight: 500;
+	}


I know this stuff is sometime unavoidable, but there's a general preference not to target component internals since components might change internal classes.

Just a fragility thing. Okay for now.

Unfortunately we don't have a way to adjust css of the modal header.

Another option for this header would be to leave it at its existing font-weight for consistency with other modals? The default across wp-admin and in Gutenberg appears to be 600 so I'm not sure if this needs to be different 🤔

(Again, not a blocker, just a thought!)

routes/content-guidelines/api.ts

routes/content-guidelines/components/block-guideline-modal.tsx

ramonjd

Thanks for the fast update @aswasif007

I gave it another smoke test.

I think an immediate follow up could be to look at @andrewserong's comments in relation to content blocks in the block list: #76187 (comment)

Anyway, let's get this in so folks can iterate. Cheers.

aswasif007 · 2026-03-10T03:09:54Z

Thanks @ramonjd and @andrewserong for the reviews and approval!

I've addressed the comments as well.

andrewserong · 2026-03-10T04:48:52Z

I've addressed the comments as well.

Nicely done, thanks for updating all of that before merge! 🚀

#76155) * Add block guidelines management * Fix spacing of the dataviews * Remove dataviews sort and filter And omit dataviews search too when there are less than 6 items * Exclude blocks that already have guidelines from add-guideline list Also, use textcontrol instead of combobox in edit mode * Show confirmation modal when deleting block guideline from table * Improve save/delete logic * Use base-style variable * Fix bootstrapBlockRegistry() placement * Add types * Use hstack wrapper for add-block-guideline btn * Do not remove block-key when removing block guideline This is because the backend expects empty string in order to delete a block * Fix issue with empty page after deleting rows * Fix mistake with wrapping up action-text in double quote * Add . after success notice text * Remove undefined keys from block entries * Add clarifying comment for setting empty string to delete a block guideline * Content Guidelines: Add actions section UI * Adds simple import and export function * Content Guidelines: Add manage access and revision screens * Content Guidelines: Search in revision history screen * Content guidelines: Use filterSortAndPaginate from DataViews to implement search in guidelines revision history screen * Content guidelines: Hide Manage Access action button for MVP * Improve spacing * Content guidelines: Use DataViews inbuilt filtering * Refetch content-guidelines after restoring a revision * Improve revision-history page styles * Content guidelines: remove manage-access from MVP * Content Guidelines: Use Notice as error message component instead of Snackbar * Content Guidelines: Addresses PR feedback: 1. Uses downloadBlob from wordpress/blob 2. Adds isRTL support to the chevron 3. Uses dateI18n to format date on revision screen 4. Adds efficient catching of error during revision restoration * Content Guidelines: Align author to the right of revision history table * Content guidelines: Rebase with #76187 * Content guideliens: Adds confirmation modal to import guidelines * Content guidelines: Updates modal sequence and copy * Content guidelines: Addresses PR feedback to:1. Fix unnecessary try/catch 2. Remov unnecessary lint escapes 3. Use memoisation to avoid rerenders * Content guidelines: Remove unnecessary overrides in CSS, where possible * Content guidelines: Use memoisation in filter and pagination to avoid rerenders * Content guidelines: Revert changes done by incorrect rebase and merge * Content guidelines: Revert unnecessary changes brought in incorrect rebase * Content guidelines: Handle guidelines import error correctly by restoring previous version * Content guidelines: Pre-emptively add override for wordpress/ui Notice component * Content guidelines: Update copy for content guidelines import error * Guidelines: Rename "Content Guidelines" to "Guidelines" in all user-facing strings Rename the feature from "Content Guidelines" to "Guidelines" across all user-facing strings (page title, menu item, experiments toggle, notices, modals, aria labels, error messages) while keeping variable and file names unchanged. This aligns with the decision to use the shorter name while the feature remains experimental. Co-Authored-By: Claude Opus 4.6 <[email protected]> * Content guidelines: Change the text 'content guidelines' to 'guidelines' in user facing interfaces * Content Guidelines: Remove lint override which is not live yet * Content guidelines: Updates copy of import error notice and removes moving revision history columns feature * Content guidelines: Updates snackbar/toast message copy --------- Co-authored-by: Ahmed Sayeed Wasif <[email protected]> Co-authored-by: Aagam Shah <[email protected]> Co-authored-by: Claude Opus 4.6 <[email protected]> Co-authored-by: aswasif007 <[email protected]> Co-authored-by: iamchughmayank <[email protected]> Co-authored-by: aagam-shah <[email protected]> Co-authored-by: fditrapani <[email protected]> Co-authored-by: saroshaga <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: Jameswlepage <[email protected]>

scruffian · 2026-03-11T10:43:09Z

I just cherry-picked this PR to the release/22.7 branch to get it included in the next release: c7b5c09

Co-authored-by: aswasif007 <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: saroshaga <[email protected]> Co-authored-by: aagam-shah <[email protected]> Co-authored-by: fditrapani <[email protected]>

#76155) * Add block guidelines management * Fix spacing of the dataviews * Remove dataviews sort and filter And omit dataviews search too when there are less than 6 items * Exclude blocks that already have guidelines from add-guideline list Also, use textcontrol instead of combobox in edit mode * Show confirmation modal when deleting block guideline from table * Improve save/delete logic * Use base-style variable * Fix bootstrapBlockRegistry() placement * Add types * Use hstack wrapper for add-block-guideline btn * Do not remove block-key when removing block guideline This is because the backend expects empty string in order to delete a block * Fix issue with empty page after deleting rows * Fix mistake with wrapping up action-text in double quote * Add . after success notice text * Remove undefined keys from block entries * Add clarifying comment for setting empty string to delete a block guideline * Content Guidelines: Add actions section UI * Adds simple import and export function * Content Guidelines: Add manage access and revision screens * Content Guidelines: Search in revision history screen * Content guidelines: Use filterSortAndPaginate from DataViews to implement search in guidelines revision history screen * Content guidelines: Hide Manage Access action button for MVP * Improve spacing * Content guidelines: Use DataViews inbuilt filtering * Refetch content-guidelines after restoring a revision * Improve revision-history page styles * Content guidelines: remove manage-access from MVP * Content Guidelines: Use Notice as error message component instead of Snackbar * Content Guidelines: Addresses PR feedback: 1. Uses downloadBlob from wordpress/blob 2. Adds isRTL support to the chevron 3. Uses dateI18n to format date on revision screen 4. Adds efficient catching of error during revision restoration * Content Guidelines: Align author to the right of revision history table * Content guidelines: Rebase with #76187 * Content guideliens: Adds confirmation modal to import guidelines * Content guidelines: Updates modal sequence and copy * Content guidelines: Addresses PR feedback to:1. Fix unnecessary try/catch 2. Remov unnecessary lint escapes 3. Use memoisation to avoid rerenders * Content guidelines: Remove unnecessary overrides in CSS, where possible * Content guidelines: Use memoisation in filter and pagination to avoid rerenders * Content guidelines: Revert changes done by incorrect rebase and merge * Content guidelines: Revert unnecessary changes brought in incorrect rebase * Content guidelines: Handle guidelines import error correctly by restoring previous version * Content guidelines: Pre-emptively add override for wordpress/ui Notice component * Content guidelines: Update copy for content guidelines import error * Guidelines: Rename "Content Guidelines" to "Guidelines" in all user-facing strings Rename the feature from "Content Guidelines" to "Guidelines" across all user-facing strings (page title, menu item, experiments toggle, notices, modals, aria labels, error messages) while keeping variable and file names unchanged. This aligns with the decision to use the shorter name while the feature remains experimental. Co-Authored-By: Claude Opus 4.6 <[email protected]> * Content guidelines: Change the text 'content guidelines' to 'guidelines' in user facing interfaces * Content Guidelines: Remove lint override which is not live yet * Content guidelines: Updates copy of import error notice and removes moving revision history columns feature * Content guidelines: Updates snackbar/toast message copy --------- Co-authored-by: Ahmed Sayeed Wasif <[email protected]> Co-authored-by: Aagam Shah <[email protected]> Co-authored-by: Claude Opus 4.6 <[email protected]> Co-authored-by: aswasif007 <[email protected]> Co-authored-by: iamchughmayank <[email protected]> Co-authored-by: aagam-shah <[email protected]> Co-authored-by: fditrapani <[email protected]> Co-authored-by: saroshaga <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: Jameswlepage <[email protected]>

aswasif007 commented Mar 5, 2026

View reviewed changes

routes/content-guidelines/utils.tsx Outdated Show resolved Hide resolved

aswasif007 commented Mar 5, 2026

View reviewed changes

routes/content-guidelines/api.ts Outdated Show resolved Hide resolved

ramonjd reviewed Mar 5, 2026

View reviewed changes

routes/content-guidelines/api.ts Outdated Show resolved Hide resolved

aswasif007 force-pushed the add/block-content-guidelines branch from 953daab to ab59a35 Compare March 6, 2026 04:50

aswasif007 requested a review from spacedmonkey as a code owner March 6, 2026 04:50

aswasif007 requested review from andrewserong and ramonjd March 6, 2026 05:01

saroshaga reviewed Mar 6, 2026

View reviewed changes

routes/content-guidelines/components/block-guideline-modal.tsx Outdated Show resolved Hide resolved

ramonjd added [Type] Enhancement A suggestion for improvement. [Feature] Guidelines An experimental feature for adding site-wide editorial rules. labels Mar 9, 2026

ramonjd assigned aswasif007 Mar 9, 2026

ramonjd reviewed Mar 9, 2026

View reviewed changes

routes/content-guidelines/components/block-guidelines.tsx Outdated Show resolved Hide resolved

aswasif007 added 12 commits March 9, 2026 13:14

Bootstrap core blocks registry with content-guidelines page

bea207a

Update store and api for block guidelines

66fe8fc

Add block guidelines management

2ef2bda

Simplify blocks registry script

5463643

Fix spacing of the dataviews

cff10f9

Remove dataviews sort and filter

a36c371

And omit dataviews search too when there are less than 6 items

Exclude blocks that already have guidelines from add-guideline list

d0e0e0f

Also, use textcontrol instead of combobox in edit mode

Show confirmation modal when deleting block guideline from table

3665b68

Improve save/delete logic

f229dee

Use base-style variable

c91aa33

Fix bootstrapBlockRegistry() placement

d9f0b24

Add types

86ba626

aswasif007 force-pushed the add/block-content-guidelines branch from 95c8815 to 86ba626 Compare March 9, 2026 07:14

saroshaga approved these changes Mar 9, 2026

View reviewed changes

iamchughmayank added a commit to iamchughmayank/gutenberg that referenced this pull request Mar 9, 2026

Content guidelines: Rebase with WordPress#76187

31c30ce

Trigger modal when block guideline row is clicked

c1af24a

andrewserong reviewed Mar 10, 2026

View reviewed changes

routes/content-guidelines/components/block-guideline-modal.tsx Show resolved Hide resolved

andrewserong reviewed Mar 10, 2026

View reviewed changes

routes/content-guidelines/components/block-guidelines.tsx Outdated Show resolved Hide resolved

andrewserong reviewed Mar 10, 2026

View reviewed changes

routes/content-guidelines/stage.tsx Outdated Show resolved Hide resolved

andrewserong reviewed Mar 10, 2026

View reviewed changes

ramonjd reviewed Mar 10, 2026

View reviewed changes

aswasif007 added 3 commits March 10, 2026 08:50

Fix translation for block guideline notice

3d89fde

Set acessibleWhenDisabled to modal buttons

d9b3a41

Fix type issues and replace for..in loop

7b00b11

ramonjd approved these changes Mar 10, 2026

View reviewed changes

aswasif007 added 3 commits March 10, 2026 08:58

Bootstrap block-registry in the beforeLoad attrib

2df6c13

Use a div-wrapper around icon to avoid having to target inner css

a8ddd23

Filter out the non-content blocks

d16afc0

ramonjd merged commit 19fb314 into WordPress:trunk Mar 10, 2026
41 of 42 checks passed

github-actions bot added this to the Gutenberg 22.8 milestone Mar 10, 2026

saroshaga mentioned this pull request Mar 10, 2026

Guidelines: Add actions for Import, Export and Revisions of guidelines #76155

Merged

iamchughmayank added a commit to iamchughmayank/gutenberg that referenced this pull request Mar 10, 2026

Content guidelines: Rebase with WordPress#76187

5b4083e

andrewserong added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Mar 11, 2026

scruffian removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Mar 11, 2026

andrewserong mentioned this pull request Mar 13, 2026

Content Guidelines: UI/UX Design Discussion #75260

Closed

	// Handle block-specific guidelines as individual meta keys.
	if ( isset( $categories['blocks'] ) && is_array( $categories['blocks'] ) ) {
	foreach ( $categories['blocks'] as $block_name => $block_data ) {
	$meta_key = Gutenberg_Content_Guidelines_Post_Type::block_name_to_meta_key( $block_name );
	$value = isset( $block_data['guidelines'] ) ? $block_data['guidelines'] : '';

	if ( ! empty( $value ) ) {
	update_post_meta( $post_id, $meta_key, $value );
	} else {
	delete_post_meta( $post_id, $meta_key );
	}
	}
	}

Conversation

aswasif007 commented Mar 5, 2026

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots

Uh oh!

github-actions bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aswasif007 Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fditrapani commented Mar 6, 2026

Uh oh!

Uh oh!

ramonjd commented Mar 9, 2026

Uh oh!

saroshaga commented Mar 9, 2026

Uh oh!

saroshaga left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fditrapani commented Mar 9, 2026

Uh oh!

aswasif007 commented Mar 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrewserong left a comment

Choose a reason for hiding this comment

Uh oh!

ramonjd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

github-actions bot commented Mar 5, 2026 •

edited

Loading

aswasif007 Mar 9, 2026 •

edited

Loading