TRY: Block Editor: Separate server-side mediaUpload key to fix nested provider loop#76137
Open
adamsilverstein wants to merge 3 commits intotrunkfrom
Open
TRY: Block Editor: Separate server-side mediaUpload key to fix nested provider loop#76137adamsilverstein wants to merge 3 commits intotrunkfrom
adamsilverstein wants to merge 3 commits intotrunkfrom
Conversation
Nested ExperimentalBlockEditorProvider instances (e.g. from BlockPreview) overwrite the upload-media store's real server-side mediaUpload with the queue interceptor, causing uploadItem() to loop endlessly. Store the original function under __unstableMediaUploadServer so it survives nesting.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
adamsilverstein
added
the
[Type] Bug
|
Size Change: +21 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
Contributor
|
While this unblocks uploading, for some reason it seems that the sideload requests aren't firing with this change, so I think things might still be getting stuck somewhere? 🤔 To check, I inspected the Network tab and looked for (Thanks for getting this alternative PR up by the way, conceptually it sounded good, but doesn't quite seem to be working how we expect) |
|
Flaky tests detected in ec67964. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22702316388
|
adamsilverstein
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where images uploaded in the site editor get stuck in an infinite loading loop when a Query Loop / Post Template block is present. The root cause: nested
ExperimentalBlockEditorProviderinstances (created byBlockPreview) overwrite the upload-media store's real server-sidemediaUploadfunction with the queue interceptor, causinguploadItem()to loop endlessly.This PR stores the original server-side upload function under a separate key (
__unstableMediaUploadServer) so it survives arbitrary nesting depth.useMediaUploadSettingsprefers this key when passing settings to the upload-media store.Alternative approach to #76124.
Bug flow (before this fix)
settings.mediaUploadwith queue interceptorBlockPreviewreads settings from block-editor store (already has interceptor)useMediaUploadSettingsextracts the interceptor (not the real function)MediaUploadProviderwrites interceptor into upload-media storeuploadItem()callssettings.mediaUpload()→ interceptor →addItems()→ infinite loopHow the fix works
__unstableMediaUploadServerdoesn't exist on incoming settings, somediaUpload(the real function) is stored__unstableMediaUploadServeralready exists from the parent, so the||fallback preserves itifblock is skipped entirely; no behavior changeTest plan
window.__clientSideMediaProcessing = true)🤖 Generated with Claude Code