Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
added
[Type] Task
|
Size Change: 0 B Total Size: 6.84 MB ℹ️ View Unchanged
|
tyxla
reviewed
Feb 27, 2026
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Nice. Just to be sure we're on the same page about the next steps: After landing this one, the plan is to update the @wordpress/components Notice component to be consistent with this one, following the new designs from #64636, before exposing this one for public consumption?
mirka
approved these changes
Feb 27, 2026
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Looks good 👍 There's a handful of code comments that were removed from the original implementation, so please check if those were intentional.
|
Flaky tests detected in 1d2805e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22488925998
|
Member
Author
Yep! That's the reason for my caution about not using this yet in Gutenberg, because we need to update styles for the
👍 I added some more clarifying code comments in 1d2805e . |
Member
Author
|
(Apologies, I neglected to copy in the props for the merge commit 😞 🙏 ) |
1 task
gziolo
pushed a commit
that referenced
this pull request
Mar 3, 2026
* UI: Add Notice component * Add CHANGELOG note for new Notice component * Fix getByRole missing aria-hidden images * Expand code comments in Notice implementation
ciampo
reviewed
Mar 20, 2026
| ActionLink, | ||
| }; | ||
|
|
||
| export type { NoticeIntent } from './types'; |
Contributor
There was a problem hiding this comment.
I just noticed that this PR exported the NoticeIntent type. Given that we usually don't export types, was this intentional or can it be removed?
Member
Author
There was a problem hiding this comment.
Good call. I don't think we need it. I'll put together a pull request to remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a new
Noticecomponent to the@wordpress/uipackage, following design specifications as considered in #64636 .Note that while this adds the new component, further work is needed in order to use it within the WordPress interface, in order to prevent disjointed appearance between
@wordpress/componentsand@wordpress/ui. In other words, usage of this component is blocked by #64636.Why?
Noticecomponent to match the new design #64636 and UpdateNoticecomponent design #67662This also addresses fundamental shortcomings of the existing notice component as raised in #74090.
How?
This follows compound component guidance, similar to what was discussed in #74090.
Example "kitchen sink" looks like the following. The implementation here is low-level, and it's expected that higher-level abstractions could facilitate common use-cases:
The implementation here leans into "intents" to express a common set of notice use-cases, with standardized colors and icons associated with each intent.
Testing Instructions
Verify Storybook stories examples:
npm run storybook:dev@wordpress/themecolor scalesScreenshots or screencast