Closed
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +110 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
Member
Author
|
I discussed this with Riad and he wants this to be a consumer decision. I'll prepare an alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #75917
What?
This PR updates
useViewso that theview.layoutproperties are ignored when loading a persisted view by always merging them on read and stripped them before persisting — using the same pattern already established for activeViewOverrides (filters and sort).Why?
The
view.layoutproperties are not user config and they are being overriden by the existing mechanism when users have saved views. See #75917 (comment)How?
Extends the existing activeViewOverrides merge/strip mechanism to also handle layout:
How to reproduce the bug
trunk.With the same steps in this branch, it will.