Conversation
ockham
left a comment
There was a problem hiding this comment.
Reproduced the issue on a fresh WordPress install, using GB 22.6.0 RC2 ✅
Then tested the fix by using the asset produced by CI for the "Build Release Artifact" workflow on this PR ✅
LGTM 🚢
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
The Gutenberg repository has been updated to include the icon assets in the plugin build. See github.com/WordPress/gutenberg/pull/75866.
Co-authored-by: mcsf <[email protected]> Co-authored-by: ockham <[email protected]>
|
I just cherry-picked this PR to the release/22.6 branch to get it included in the next release: 91c66f3 |
The Gutenberg repository has been updated to include the icon assets in the plugin build. See github.com/WordPress/gutenberg/pull/75866. This also updates the hash value.
|
It looks like this never made its way into |
Co-authored-by: mcsf <[email protected]> Co-authored-by: ockham <[email protected]>
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: aa548e6 |
This updates the pinned hash from the `gutenberg` from `7b7fa2bc97a8029a302bd6511cf0d206b5953172` to `9b8144036fa5faf75de43d4502ff9809fcf689ad`. The following changes are included: - Use V2 Yjs methods for HTTP Polling (WordPress/gutenberg#76304) - Plugin: Include Icons assets in ZIP (WordPress/gutenberg#75866) - Ensure consistent, repeatable build results when inlining WASM files via `wasmInlinePlugin` (WordPress/gutenberg#76113) - Account `IS_WORDPRESS_CORE` is set. (WordPress/gutenberg#76334) - Block Visibility: Add `fetchpriority=auto` to `IMG` tags in blocks with conditional viewport visibility to prevent potential erroneous high loading priority (WordPress/gutenberg#76302) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/7b7fa2bc97a8029a302bd6511cf0d206b5953172…9b8144036fa5faf75de43d4502ff9809fcf689ad. See #64595, #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61870 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `7b7fa2bc97a8029a302bd6511cf0d206b5953172` to `9b8144036fa5faf75de43d4502ff9809fcf689ad`. The following changes are included: - Use V2 Yjs methods for HTTP Polling (WordPress/gutenberg#76304) - Plugin: Include Icons assets in ZIP (WordPress/gutenberg#75866) - Ensure consistent, repeatable build results when inlining WASM files via `wasmInlinePlugin` (WordPress/gutenberg#76113) - Account `IS_WORDPRESS_CORE` is set. (WordPress/gutenberg#76334) - Block Visibility: Add `fetchpriority=auto` to `IMG` tags in blocks with conditional viewport visibility to prevent potential erroneous high loading priority (WordPress/gutenberg#76302) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/7b7fa2bc97a8029a302bd6511cf0d206b5953172…9b8144036fa5faf75de43d4502ff9809fcf689ad. See #64595, #64393. Built from https://develop.svn.wordpress.org/trunk@61870 git-svn-id: http://core.svn.wordpress.org/trunk@61157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
🤦 |
What?
Follow-up of #72215, #71878, #74943
Include in the Gutenberg plugin ZIP file the assets (SVG and manifest.php) of the core library of icons.
Why?
Without these assets, the new Icon block (#71227) won't show any available icons for users of the Gutenberg plugin.
How?
Include the assets in the
zipcommand invocation.Why now?
This has gone unnoticed so far because, in Gutenberg, all testing happens by building the project from scratch and running the tests in that environment. Meanwhile, in Core, there's a dedicated Gutenberg-to-Core copy process that operates similarly, which explains why this was missed in the backport of the Icons API (Trac). Luckily, @desrosj is experimenting with WordPress/wordpress-develop#11019 and noticed the absence of icons there.
Testing Instructions
npm run build:plugin-zipgutenberg.zipfile in a fresh WordPres site/wp/v2/icons