Icon Block: Clean up selectors config by aaronrobertshaw · Pull Request #75786 · WordPress/gutenberg

aaronrobertshaw · 2026-02-20T16:33:17Z

What?

Simplifies the selectors configuration in the Icon block's block.json.

Why?

The old config explicitly listed per-feature selectors (color.root, border.root, spacing.padding, dimensions.root) that all pointed to .wp-block-icon svg. This can be expressed more concisely by setting the top-level root to .wp-block-icon svg and only overriding spacing.margin to .wp-block-icon, since margin is the one property that should target the outer wrapper.

The old config also included a dimensions.width selector key, which had no effect given in already matched the dimensions root.

How?

Replaces the per-feature selector overrides with a single top-level root selector set to .wp-block-icon svg, and an explicit spacing.margin override set to .wp-block-icon.

Testing

No functional changes. The resolved selector for each feature remains the same:

Feature	Selector
color	`.wp-block-icon svg`
border	`.wp-block-icon svg`
spacing.padding	`.wp-block-icon svg`
spacing.margin	`.wp-block-icon`
dimensions	`.wp-block-icon svg

Smoke test global styles on the icon block

shimotmk · 2026-02-21T01:49:29Z

The code has become shorter and simpler, but the selectors for Additional CSS will also change.

Code rendered by Global style
before

:root :where(.wp-block-icon) {
    color: red;
}

after

:root :where(.wp-block-icon svg) {
    color: red;
}

Code rendered by Additional CSS of the block

:root :where(.wp-custom-css-*) {
    color: blue;
}

github-actions · 2026-02-21T01:49:39Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronrobertshaw <[email protected]>
Co-authored-by: andrewserong <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: shimotmk <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

t-hamano · 2026-02-21T05:59:32Z

I wasn't aware that Additional CSS via global styles took selectors into account.

Before moving forward with this PR, I think it's worth considering whether Additional CSS on block instances should take selectors into account as well.

aaronrobertshaw · 2026-02-21T20:59:54Z

Thanks for flagging that issue @shimotmk 👍

It looks like there was an oversight in the implementation of the custom CSS feature or the block selectors API. Either way I have a fix up in #75799.

On trunk now, if a block tried to define a selector for the css block supports feature, it would actually cause the custom CSS to be filtered out of the node being processed and result in no custom CSS being generated. So regardless of the clean up here it is an issue worth fixing.

I've updated this PR to be based off #75799 as well as made the css selector the default block class e.g. 'css' => '.wp-block-icon'

I wasn't aware that Additional CSS via global styles took selectors into account.

@t-hamano the custom CSS feature only partly used the selectors. If selectors are defined for a block type, the root selector is assigned as the primary selector for a theme.json node. The problem was the custom CSS feature assumed that the block would always have the block wrapper element as the root selector. So for example, the Button block would not be able to generate custom CSS easily targeting the block wrapper.

The fix in #75799 should allow block authors proper control over selectors for custom CSS now.

t-hamano · 2026-03-03T12:33:46Z

Sorry for the late reply.

Since #75799 has been merged, can we move this PR forward?

aaronrobertshaw · 2026-03-03T18:44:52Z

Thanks for the nudge @t-hamano 👍

I've rebased this and resolved the conflicts. It should be right for a quick smoke test and final review.

andrewserong

Looking good in global styles:

And overrides at the individual block level still work as expected, too:

LGTM 🚀

t-hamano

LGTM! Thanks for the update.

Just to be sure, the selectors generated by this PR won't change at all, right? However, it might be safer to backport this PR to 7.0. What do you think?

andrewserong · 2026-03-04T22:17:14Z

However, it might be safer to backport this PR to 7.0. What do you think?

That feels safer to me, since the icon block is being introduced in 7.0, it seems good to get this in for that release, too.

aaronrobertshaw · 2026-03-05T00:29:58Z

Just to be sure, the selectors generated by this PR won't change at all, right?

That's correct but as has been discussed there's no harm in backporting this so the icon block is clean from the start.

Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: shimotmk <[email protected]>

github-actions · 2026-03-05T00:31:39Z

I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 86efbf7

CI run: #11167. See #64595. --- I've included a log of the Gutenberg changes with the following command: git log --reverse --format="- %s" 022d8dd3d461f91b15c1f0410649d3ebb027207f..e499abfb843a43ac88455ca319220c5f181e1cf3 | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy - Add documentation for contentRole and listView block supports (WordPress/gutenberg#75903) - Interactivity Router: fix back and forward navigation after refresh (WordPress/gutenberg#75927) - Real-time collaboration: Fix disconnect dialog on navigate (WordPress/gutenberg#75886) - Real Time Collab: Throttle syncing for inactive tabs. (WordPress/gutenberg#75843) - Components: Specify line-height to avoid inheriting default values (WordPress/gutenberg#75880) - Pattern Editing: Fix sibling blocks to edited pattern not being disabled (WordPress/gutenberg#75994) - Sync connector PHP behavior with Core backport changes (WordPress/gutenberg#75968) - Connectors: Avoid manual string concatenation (WordPress/gutenberg#75997) - DataForm: fix field label for panel (should not be uppercase) (WordPress/gutenberg#75944) - Views: add support for more overrides (all developer-defined config) (WordPress/gutenberg#75971) - Use homeUrl instead of siteUrl for link badge evaluations (WordPress/gutenberg#75978) - DataViews: Right-align `integer` and `number` fields (WordPress/gutenberg#75917) - Navigation Link: Compare internal links by host instead of origin (WordPress/gutenberg#76015) - Fix: Skip scaled image sideload for images below big image threshold (WordPress/gutenberg#75990) - Client side media cherry pick for 7.0 (WordPress/gutenberg#75998) - Show transform dropdown previews on focus as well as hover (WordPress/gutenberg#75940) (WordPress/gutenberg#75992) - RTC: Fix syncing of emoji / surrogate pairs (WordPress/gutenberg#76049) - [Real-time Collaboration] Fix sync issue on refresh (WordPress/gutenberg#76017) - Real-time collaboration: Improve disconnect dialog (WordPress/gutenberg#75970) - DataViews: Fix filter toggle flickering when there are locked or primary filters (WordPress/gutenberg#75913) (WordPress/gutenberg#76068) - Connectors: Dynamically register providers from WP AI Client registry (WordPress/gutenberg#76014) - PHP-only Blocks: Reflect bound attribute values in inspector controls (WordPress/gutenberg#76040) - Fix: Set quality and strip metadata in client-side image resize (WordPress/gutenberg#76029) - RTC: Prevent duplicate poll cycles (WordPress/gutenberg#76059) - RTC: Fix stale CRDT document persisted on save (WordPress/gutenberg#75975) - RTC: Disable multiple collaborators if meta boxes are present (WordPress/gutenberg#75939) - Directly inject styles in overlay to make styles stay consistently mounted (WordPress/gutenberg#75700) - Real-time collaboration: Fix comment syncing on site editor (WordPress/gutenberg#75746) - Real-time Collaboration: Bug fix for CRDT user selection and add tests (WordPress/gutenberg#75075) - RTC: Updates from backport PR (WordPress/gutenberg#75711) - RTC: Fix undefined array_first() call in sync storage (WordPress/gutenberg#75869) - RTC: Fix fallthrough for sync update switch statement (WordPress/gutenberg#76060) - Real-time collaboration: Remove block client IDs from Awareness, fix "Show Template" view (WordPress/gutenberg#75590) - RTC: Add session activity notifications (WordPress/gutenberg#76065) - Prevent non-reproducible Sass/CSS builds. (WordPress/gutenberg#76098) - Block toolbar and context menu: hide pattern actions in Revisions UI (WordPress/gutenberg#76066) - Try enabling style variation transforms for blocks in contentOnly mode (WordPress/gutenberg#75761) - Block toolbar: hide styles dropdown in Revisions UI (WordPress/gutenberg#76119) - Image block: fix lightbox srcset size (WordPress/gutenberg#76092) - Fix writing flow navigation for annotation style, or any other block with border radius (WordPress/gutenberg#76072) - Image: Hide 'Set as featured image' for in-editor revisions (WordPress/gutenberg#76123) - Connectors: Gate unavailable install actions behind install capability (WordPress/gutenberg#75980) - build: Exclude experimental pages from Core builds (WordPress/gutenberg#76038) - HTML & Shortcode: Disable viewport visibility support (WordPress/gutenberg#76138) - RTC: Verify client ID to avoid awareness mutation (WordPress/gutenberg#76056) - wp-build: Do not remove Core's default script modules registration (WordPress/gutenberg#75705) - wp-build: Deregister script modules before re-registering (WordPress/gutenberg#75909) - Remove `! function_exists()` checks from PHP templates (WordPress/gutenberg#76062) - Connectors: Update page identifier to options-connectors (WordPress/gutenberg#76156) - Connectors: Align init hook priorities with Core overrides (WordPress/gutenberg#76161) - Icon Block: Clean up selectors config (WordPress/gutenberg#75786) - Icons: Fix incorrect icon slug (WordPress/gutenberg#76165) - RTC: Enable RTC by default (WordPress/gutenberg#75739) - Rename and visibility modals: gate shortcuts behind canEditBlock to prevent triggering in revisions UI (WordPress/gutenberg#76168) - Fix: Block style variations not rendering in Site Editor Patterns page (WordPress/gutenberg#76122) - Client-side media processing: only use media upload provider when not in preview mode (WordPress/gutenberg#76124) - Notes: Disable for in-editor revisions (WordPress/gutenberg#76180) - Core Data: Support reading revision data in useEntityProp (fixes footnotes in revisions UI) (WordPress/gutenberg#76106) - Client-side media processing: Try plumbing invalidation to the block-editor's mediaUpload onSuccess callback (WordPress/gutenberg#76173) - Connectors: Improve responsive layout on small screens (WordPress/gutenberg#76186) - Interactivity API: Fix router initialization race condition on Safari/Firefox (WordPress/gutenberg#76053) (WordPress/gutenberg#76191) - Interactivity: Fix crypto.randomUUID crash in non-secure contexts (WordPress/gutenberg#76151) git-svn-id: https://develop.svn.wordpress.org/trunk@61843 602fd350-edb4-49c9-b593-d223f7449a82

CI run: WordPress/wordpress-develop#11167. See #64595. --- I've included a log of the Gutenberg changes with the following command: git log --reverse --format="- %s" 022d8dd3d461f91b15c1f0410649d3ebb027207f..e499abfb843a43ac88455ca319220c5f181e1cf3 | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy - Add documentation for contentRole and listView block supports (WordPress/gutenberg#75903) - Interactivity Router: fix back and forward navigation after refresh (WordPress/gutenberg#75927) - Real-time collaboration: Fix disconnect dialog on navigate (WordPress/gutenberg#75886) - Real Time Collab: Throttle syncing for inactive tabs. (WordPress/gutenberg#75843) - Components: Specify line-height to avoid inheriting default values (WordPress/gutenberg#75880) - Pattern Editing: Fix sibling blocks to edited pattern not being disabled (WordPress/gutenberg#75994) - Sync connector PHP behavior with Core backport changes (WordPress/gutenberg#75968) - Connectors: Avoid manual string concatenation (WordPress/gutenberg#75997) - DataForm: fix field label for panel (should not be uppercase) (WordPress/gutenberg#75944) - Views: add support for more overrides (all developer-defined config) (WordPress/gutenberg#75971) - Use homeUrl instead of siteUrl for link badge evaluations (WordPress/gutenberg#75978) - DataViews: Right-align `integer` and `number` fields (WordPress/gutenberg#75917) - Navigation Link: Compare internal links by host instead of origin (WordPress/gutenberg#76015) - Fix: Skip scaled image sideload for images below big image threshold (WordPress/gutenberg#75990) - Client side media cherry pick for 7.0 (WordPress/gutenberg#75998) - Show transform dropdown previews on focus as well as hover (WordPress/gutenberg#75940) (WordPress/gutenberg#75992) - RTC: Fix syncing of emoji / surrogate pairs (WordPress/gutenberg#76049) - [Real-time Collaboration] Fix sync issue on refresh (WordPress/gutenberg#76017) - Real-time collaboration: Improve disconnect dialog (WordPress/gutenberg#75970) - DataViews: Fix filter toggle flickering when there are locked or primary filters (WordPress/gutenberg#75913) (WordPress/gutenberg#76068) - Connectors: Dynamically register providers from WP AI Client registry (WordPress/gutenberg#76014) - PHP-only Blocks: Reflect bound attribute values in inspector controls (WordPress/gutenberg#76040) - Fix: Set quality and strip metadata in client-side image resize (WordPress/gutenberg#76029) - RTC: Prevent duplicate poll cycles (WordPress/gutenberg#76059) - RTC: Fix stale CRDT document persisted on save (WordPress/gutenberg#75975) - RTC: Disable multiple collaborators if meta boxes are present (WordPress/gutenberg#75939) - Directly inject styles in overlay to make styles stay consistently mounted (WordPress/gutenberg#75700) - Real-time collaboration: Fix comment syncing on site editor (WordPress/gutenberg#75746) - Real-time Collaboration: Bug fix for CRDT user selection and add tests (WordPress/gutenberg#75075) - RTC: Updates from backport PR (WordPress/gutenberg#75711) - RTC: Fix undefined array_first() call in sync storage (WordPress/gutenberg#75869) - RTC: Fix fallthrough for sync update switch statement (WordPress/gutenberg#76060) - Real-time collaboration: Remove block client IDs from Awareness, fix "Show Template" view (WordPress/gutenberg#75590) - RTC: Add session activity notifications (WordPress/gutenberg#76065) - Prevent non-reproducible Sass/CSS builds. (WordPress/gutenberg#76098) - Block toolbar and context menu: hide pattern actions in Revisions UI (WordPress/gutenberg#76066) - Try enabling style variation transforms for blocks in contentOnly mode (WordPress/gutenberg#75761) - Block toolbar: hide styles dropdown in Revisions UI (WordPress/gutenberg#76119) - Image block: fix lightbox srcset size (WordPress/gutenberg#76092) - Fix writing flow navigation for annotation style, or any other block with border radius (WordPress/gutenberg#76072) - Image: Hide 'Set as featured image' for in-editor revisions (WordPress/gutenberg#76123) - Connectors: Gate unavailable install actions behind install capability (WordPress/gutenberg#75980) - build: Exclude experimental pages from Core builds (WordPress/gutenberg#76038) - HTML & Shortcode: Disable viewport visibility support (WordPress/gutenberg#76138) - RTC: Verify client ID to avoid awareness mutation (WordPress/gutenberg#76056) - wp-build: Do not remove Core's default script modules registration (WordPress/gutenberg#75705) - wp-build: Deregister script modules before re-registering (WordPress/gutenberg#75909) - Remove `! function_exists()` checks from PHP templates (WordPress/gutenberg#76062) - Connectors: Update page identifier to options-connectors (WordPress/gutenberg#76156) - Connectors: Align init hook priorities with Core overrides (WordPress/gutenberg#76161) - Icon Block: Clean up selectors config (WordPress/gutenberg#75786) - Icons: Fix incorrect icon slug (WordPress/gutenberg#76165) - RTC: Enable RTC by default (WordPress/gutenberg#75739) - Rename and visibility modals: gate shortcuts behind canEditBlock to prevent triggering in revisions UI (WordPress/gutenberg#76168) - Fix: Block style variations not rendering in Site Editor Patterns page (WordPress/gutenberg#76122) - Client-side media processing: only use media upload provider when not in preview mode (WordPress/gutenberg#76124) - Notes: Disable for in-editor revisions (WordPress/gutenberg#76180) - Core Data: Support reading revision data in useEntityProp (fixes footnotes in revisions UI) (WordPress/gutenberg#76106) - Client-side media processing: Try plumbing invalidation to the block-editor's mediaUpload onSuccess callback (WordPress/gutenberg#76173) - Connectors: Improve responsive layout on small screens (WordPress/gutenberg#76186) - Interactivity API: Fix router initialization race condition on Safari/Firefox (WordPress/gutenberg#76053) (WordPress/gutenberg#76191) - Interactivity: Fix crypto.randomUUID crash in non-secure contexts (WordPress/gutenberg#76151) Built from https://develop.svn.wordpress.org/trunk@61843 git-svn-id: http://core.svn.wordpress.org/trunk@61130 1a063a9b-81f0-0310-95a4-ce76da25c4cd

aaronrobertshaw requested review from shimotmk and t-hamano February 20, 2026 16:33

aaronrobertshaw self-assigned this Feb 20, 2026

aaronrobertshaw requested review from ajitbohra and fabiankaegy as code owners February 20, 2026 16:33

aaronrobertshaw added [Type] Code Quality Issues or PRs that relate to code quality [Block] Icon Affects the Icon block labels Feb 20, 2026

github-actions bot added the [Package] Block library /packages/block-library label Feb 20, 2026

aaronrobertshaw mentioned this pull request Feb 21, 2026

Custom CSS: Allow defining custom selector for this global styles feature #75799

Merged

aaronrobertshaw changed the base branch from trunk to fix/custom-css-feature-selector February 21, 2026 20:49

aaronrobertshaw force-pushed the update/cleanup-icon-block-selectors branch from b8cd987 to 99f48d5 Compare February 21, 2026 20:49

aaronrobertshaw force-pushed the fix/custom-css-feature-selector branch from 1037d3f to 70d8fac Compare February 21, 2026 21:25

aaronrobertshaw requested a review from tellthemachines as a code owner February 21, 2026 21:25

aaronrobertshaw force-pushed the update/cleanup-icon-block-selectors branch from 977dd57 to 3674751 Compare February 21, 2026 22:12

aaronrobertshaw force-pushed the fix/custom-css-feature-selector branch from c1906f4 to cddc430 Compare February 23, 2026 21:27

Base automatically changed from fix/custom-css-feature-selector to trunk February 25, 2026 06:51

aaronrobertshaw added 2 commits March 3, 2026 19:43

Icon Block: Clean up selectors config

d311624

Make block wrapper base selector for custom css

c1b8a03

aaronrobertshaw force-pushed the update/cleanup-icon-block-selectors branch from 3674751 to c1b8a03 Compare March 3, 2026 18:43

andrewserong approved these changes Mar 3, 2026

View reviewed changes

t-hamano approved these changes Mar 4, 2026

View reviewed changes

t-hamano added the Backport to WP 7.0 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 4, 2026

aaronrobertshaw merged commit 3d919e0 into trunk Mar 5, 2026
44 of 45 checks passed

aaronrobertshaw deleted the update/cleanup-icon-block-selectors branch March 5, 2026 00:30

github-actions bot added this to the Gutenberg 22.8 milestone Mar 5, 2026

github-actions bot removed the Backport to WP 7.0 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 5, 2026

github-actions bot added the Backported to WP Core Pull request that has been successfully merged into WP Core label Mar 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Icon Block: Clean up selectors config#75786

Icon Block: Clean up selectors config#75786
aaronrobertshaw merged 2 commits intotrunkfrom
update/cleanup-icon-block-selectors

aaronrobertshaw commented Feb 20, 2026

Uh oh!

shimotmk commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026 •

edited

Loading

Uh oh!

t-hamano commented Feb 21, 2026

Uh oh!

aaronrobertshaw commented Feb 21, 2026

Uh oh!

t-hamano commented Mar 3, 2026

Uh oh!

aaronrobertshaw commented Mar 3, 2026

Uh oh!

andrewserong left a comment

Uh oh!

t-hamano left a comment

Uh oh!

andrewserong commented Mar 4, 2026

Uh oh!

aaronrobertshaw commented Mar 5, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

aaronrobertshaw commented Feb 20, 2026

What?

Why?

How?

Testing

Uh oh!

shimotmk commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

t-hamano commented Feb 21, 2026

Uh oh!

aaronrobertshaw commented Feb 21, 2026

Uh oh!

t-hamano commented Mar 3, 2026

Uh oh!

aaronrobertshaw commented Mar 3, 2026

Uh oh!

andrewserong left a comment

Choose a reason for hiding this comment

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

andrewserong commented Mar 4, 2026

Uh oh!

aaronrobertshaw commented Mar 5, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Feb 21, 2026 •

edited

Loading