Site Title : Migrate to Text-Align Block Support#75551
Merged
Conversation
shail-mehta
added
[Type] Enhancement
|
Size Change: +62 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1f64229. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22034306270
|
shail-mehta
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
27 tasks
t-hamano
reviewed
Feb 16, 2026
| type: 'block', | ||
| blocks: [ 'core/site-title' ], | ||
| transform: ( { isLink, linkTarget } ) => { | ||
| transform: ( { isLink, linkTarget, style } ) => { |
Contributor
There was a problem hiding this comment.
I don't think the Site Logo block supports textAlign in the first place.
Comment on lines
+1
to
+5
| <!-- wp:site-title {"level":2,"style":{"typography":{"textAlign":"left"}}} /--> | ||
|
|
||
| <!-- wp:site-title {"level":2,"style":{"typography":{"textAlign":"center"}}} /--> | ||
|
|
||
| <!-- wp:site-title {"level":2,"style":{"typography":{"textAlign":"right"}}} /--> |
Contributor
There was a problem hiding this comment.
This is odd. The heading level of the Site Title block is 1 by default, so why is it being transformed to 2?
shail-mehta
force-pushed
the
migrate/site-title-text-align
branch
from
1f64229 to
d5ebc25
Compare
Member
Author
|
I have fixed test data issue and also reverted |
t-hamano
reviewed
Feb 23, 2026
| const blockProps = useBlockProps( { | ||
| className: clsx( { | ||
| [ `has-text-align-${ textAlign }` ]: textAlign, | ||
| 'wp-block-site-title__placeholder': ! canUserEdit && ! title, |
Contributor
There was a problem hiding this comment.
Same as the feedback here. The wp-block-site-title__placeholder class cannot be deleted.
const blockProps = useBlockProps( {
className:
! canUserEdit && ! title && 'wp-block-site-title__placeholder',
} );
shail-mehta
force-pushed
the
migrate/site-title-text-align
branch
from
8d33655 to
c3d365d
Compare
Member
Author
|
I have added missing class in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #60763
Migrates the
Site Titleblock to use the textAlign block support instead of a customtextAlignattribute. As a consequence it also enables global styles support fortextAlignfor theSite Title.Why?
The
Site Titleblock currently implements its own text alignment logic with a custom align attribute, duplicating code that should be handled by the centralizedSite Titleblock support. This migration reduces code duplication and consolidates alignment handling across blocks.How?
Replaces the custom logic with the block supports, adds deprecation and fixes transforms.
Testing Instructions
Site Titleblock and test text alignment (left, center, right)Site Titleblocks that have alignment set