Skip to content

Upload Media: Rename vips.ts to index.ts and use file: reference#75547

Closed
adamsilverstein wants to merge 2 commits intoWordPress:trunkfrom
adamsilverstein:75544-followup
Closed

Upload Media: Rename vips.ts to index.ts and use file: reference#75547
adamsilverstein wants to merge 2 commits intoWordPress:trunkfrom
adamsilverstein:75544-followup

Conversation

@adamsilverstein
Copy link
Member

@adamsilverstein adamsilverstein commented Feb 15, 2026

Summary

  • Rename vips.ts to index.ts in packages/upload-media/src/store/utils/, removing the redundant re-export index.ts file
  • Change @wordpress/vips dependency from "1.0.0-prerelease" to "file:../vips" to match monorepo conventions
  • Update test import path from ../utils/vips to ../utils

Closes #75544

Test plan

  • Verify the upload-media package builds successfully
  • Verify existing vips-related unit tests pass
  • Confirm no other imports reference the old utils/vips path

@adamsilverstein
Rename vips.ts to index.ts and use file: ref for vips
b53d383 
Remove the redundant re-export index.ts and rename vips.ts
in its place. Use file:../vips for the monorepo dependency
instead of a hardcoded prerelease version.
@github-actions
Copy link

github-actions bot commented Feb 15, 2026 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: adamsilverstein <[email protected]>
Co-authored-by: andrewserong <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@adamsilverstein adamsilverstein added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Client Side Media Media processing in the browser with WASM labels Feb 15, 2026
@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 7.0 Editor Tasks Feb 15, 2026
@adamsilverstein adamsilverstein added [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended and removed [Type] Task Issues or PRs that have been broken down into an individual action to take labels Feb 15, 2026
@andrewserong
Copy link
Contributor

andrewserong commented Feb 17, 2026

I'll just give this a quick rebase as it was opened before #75081 landed.

@andrewserong andrewserong mentioned this pull request Feb 17, 2026
Merged
@andrewserong
Copy link
Contributor

andrewserong commented Feb 17, 2026

Edit: looks like I don't have access to force push to this branch, so I've copied the (rebased) changes over into #75646 in case that helps us land this change quicker.

@andrewserong
Copy link
Contributor

andrewserong commented Feb 18, 2026

Update: I've merged in #75646 (just a rebase of this PR), so I'll close this one out now. Thanks for the follow-up, Adam! 🙇

@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 7.0 Editor Tasks Feb 18, 2026
@andrewserong andrewserong mentioned this pull request Feb 18, 2026
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsnajdr jsnajdr Awaiting requested review from jsnajdr

Assignees

No one assigned

Labels

[Feature] Client Side Media Media processing in the browser with WASM [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Projects

WordPress 7.0 Editor Tasks
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upload Media: follow up for PR feedback

2 participants

@adamsilverstein @andrewserong

Comments