ExternalLink: Prevent Twemoji from replacing arrow#75538
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
added
[Type] Bug
|
Size Change: +14 B (0%) Total Size: 3.03 MB
ℹ️ View Unchanged
|
Contributor
|
I honestly wish it wasn't necessary, but given it is, thanks for the work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #75378
Adds the
wp-exclude-emojiclass to theExternalLinkarrow span to prevent WordPress's bundled Twemoji script from replacing the ↗ arrow character with an emoji image.Why?
In contexts where Twemoji is active (currently the site editor), the ↗ / ↖ arrow glyphs rendered by
ExternalLinkget replaced by Twemoji images, resulting in a visually broken appearance.How?
Adds
wp-exclude-emojito the arrow<span>'s class list. This is a class recognized by WordPress's Twemoji integration (wp-emoji-release.min.js) that tells it to skip emoji replacement for the element's contents.Testing Instructions
wp-admin/site-editor.php, notwp-admin/admin.php?page=site-editor-v2).ExternalLinkinstance, for example Design ▸ Styles ▸ Additional CSS (from hamburger menu).Screenshots or screencast