Merged
Conversation
jsnajdr
requested review from
ajitbohra,
gigitux,
ntsekouras and
oandregal
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
[Package] Compose
jsnajdr
force-pushed
the
fix/use-ref-initial-values
branch
from
d2ac096 to
4cbcf5f
Compare
|
Size Change: +32 B (0%) Total Size: 3.03 MB
ℹ️ View Unchanged
|
aduth
reviewed
Feb 13, 2026
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
There seem to be a number of instances remaining after the changes here in .js files, do those need to be updated as well?
e.g.
gutenberg/packages/block-editor/src/components/link-control/index.js
Lines 228 to 230 in 4cbcf5f
(plus many more)
| */ | ||
| function useHandleOnload( containerRef: React.RefObject< HTMLDivElement > ) { | ||
| function useHandleOnload( | ||
| containerRef: React.RefObject< HTMLDivElement | null > |
Member
Author
There was a problem hiding this comment.
containerRef is a ref created with useRef:
const containerRef = useRef<HtmlDivElement>(null)and this call returns a RefObject<HtmlDivElement|null>. It's an object whose .current field can be null and the ref is passed to a div as <div ref={containerRef}>. React is really going to assign null values there.
That's why useHandleOnload needs to have compatible types. This is something you'll see after upgrading to React 19 which has bugfixed ref types. Typechecking with React 18 doesn't detect this. But the change is compatible.
Member
Author
Thanks for noticing this. These files are not typechecked, usually because given package's |
aduth
approved these changes
Feb 13, 2026
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Thanks for clarifying those points. LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spinoff from React 19 migration (#61521) which fixes many calls to
useRef.First of all, React 19 types require that
useRefis always called with one argument, the initial value. Passing zero arguments is no longer an option, even when it'sundefined.Second, we need to carefully distinguish between:
useRef<T>(null)which returns a ref that is not mutable, intended to be passed to a component. Like<div ref={ref}>. You can't manually assign.current.useRef<T>(undefined)which returns a mutable ref that is iniitally not set. You can assign.currentmanually.useRef<T | null>(null)which can be used to create a mutable ref withnullinitial value. Without the| nullsuffix in the type the ref wouldn't be mutable.This PR improves compatibility with React 19 types while still using React 18. In React 19 there will be additional change: the
MutableRefObjectis deprecated and no longer used, and all refs are mutable. The subtle distinctions betweennullandundefineddescribed above won't be relevant any more.