Skip to content

Blocks: Allow the Loginout block as an inner block in the Navigation Submenu block#75497

Merged
dmsnell merged 1 commit into
WordPress:trunkfrom
im3dabasia:try/loginout-block-nav-sub-menu
Jun 4, 2026
Merged

Blocks: Allow the Loginout block as an inner block in the Navigation Submenu block#75497
dmsnell merged 1 commit into
WordPress:trunkfrom
im3dabasia:try/loginout-block-nav-sub-menu

Conversation

@im3dabasia
Copy link
Copy Markdown
Contributor

What?

Closes #75408

Allow the Login/out block to be inserted and moved inside a Navigation Submenu block.

Why?

Currently, the Login/out block cannot be added as a sub-menu item inside the Navigation block. This prevents a common pattern such as having a “My Account” parent item with “Logout” as a child item.

This PR enables that expected behavior.

How?

Updates the allowed inner blocks configuration for wp:navigation-submenu to include wp:loginout.

Testing Instructions

  1. Add a Navigation block to a post or template and start editing it.
  2. Add a few menu items (e.g., pages).
  3. Convert one of the items into a Submenu and add at least one child item.
  4. Insert the Login/out block.
  5. Move the Login/out block inside the Submenu.
  6. Verify it can be inserted and nested without errors.

Screenshots or screencast

Image
Screen.Recording.2026-02-12.at.11.00.48.AM.mov

@im3dabasia im3dabasia added [Type] Enhancement A suggestion for improvement. [Block] Login/out Affects the Login/out Block [Block] Submenu Affects the Submenu Block - for submenus in navigation labels Feb 13, 2026
@github-actions github-actions Bot added the [Package] Block library /packages/block-library label Feb 13, 2026
@im3dabasia im3dabasia marked this pull request as ready for review February 13, 2026 09:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 13, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: Soean <[email protected]>
Co-authored-by: Drivingralle <[email protected]>
Co-authored-by: dmsnell <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Drivingralle
Copy link
Copy Markdown
Contributor

I just tested the PR and it's working.

Copy link
Copy Markdown
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dmsnell
Copy link
Copy Markdown
Member

dmsnell commented Jun 4, 2026

cc: @getdave seems like this is a positive change, but I’m not familiar with what decisions go into the allowed blocks in the submenu. Would love your review on this.

@dmsnell dmsnell merged commit f60ce2a into WordPress:trunk Jun 4, 2026
55 checks passed
@github-actions github-actions Bot added this to the Gutenberg 23.4 milestone Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Login/out Affects the Login/out Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow wp:loginout inside of wp:navigation-submenu

4 participants