Theme: Fix gap token migration guide in changelog#75492
Conversation
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Great catches! Confirmed accurate based on the diff.
As with your other pull request, I also independently verified this (and other potential inaccuracies) with a "spot the problems" AI-assisted session and it came up with the same result.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 1e0dce8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21964010907
|
2 participants
What?
Follow up to #75054
Fixes the gap token migration guide in the
@wordpress/themechangelog.Why?
The migration guide had two errors:
--wpds-dimension-gap-xlwas listed as mapping to--wpds-dimension-gap-2xl(32px), but the oldxltoken was 40px, which corresponds to--wpds-dimension-gap-3xl.--wpds-dimension-gap-2xlwas listed as an old token to migrate from, but it didn't exist in the old scale (which ended atxl).Changes can be confirmed in the design tokens stylesheet diff here.
Testing Instructions
Review the changelog at
packages/theme/CHANGELOG.mdand verify the gap migration entries match the actual token values.