Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
[Type] Bug
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the block settings (context) menu behavior so it closes after clicking “Disconnect pattern” on an unsynced pattern, aligning it with other block menu actions.
Changes:
- Adds an
onClosecallback prop toPatternsManageButton. - Calls
onCloseafter performing the “Disconnect pattern” action. - Wires
BlockSettingsMenuControls’sonCloseintoPatternsManageButton.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/patterns/src/components/patterns-manage-button.js |
Accepts onClose and invokes it after disconnecting (including unsynced patterns). |
packages/patterns/src/components/index.js |
Passes onClose from BlockSettingsMenuControls into PatternsManageButton. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Size Change: +9 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
ramonjd
commented
Feb 17, 2026
| { selectedClientIds.length === 1 && ( | ||
| <PatternsManageButton | ||
| clientId={ selectedClientIds[ 0 ] } | ||
| onClose={ onClose } |
Member
Author
There was a problem hiding this comment.
I can reproduce when creating an unsynced pattern too. I'll see if I can update that as well
ramonjd
force-pushed
the
update/close-context-menu-disconnect-patterns
branch
from
2bdc4e6 to
ebb5dc5
Compare
ramonjd
commented
Feb 17, 2026
| } | ||
| ); | ||
| setIsModalOpen( false ); | ||
| closeBlockSettingsMenu(); |
Member
Author
There was a problem hiding this comment.
Closes the context menu onSuccess and onFail.
talldan
approved these changes
Mar 5, 2026
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Seems like a reasonable fix, definitely better than what's in trunk.
talldan
added
the
Backport to WP 7.0 Beta/RC
Member
Author
Thanks @talldan! |
…led consistently on modal close and block conversion actions.
ramonjd
force-pushed
the
update/close-context-menu-disconnect-patterns
branch
from
c62af53 to
bb19fb6
Compare
github-actions
bot
removed
the
Backport to WP 7.0 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 7, 2026
…ed pattern menu items (#75405) Co-authored-by: ramonjd <[email protected]> Co-authored-by: talldan <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 613d271 |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Mar 9, 2026
This updates the pinned hash from the `gutenberg` from `f4d8a5803aa2fbe26e7d9af4d17e80a622b7bab8` to `7b7fa2bc97a8029a302bd6511cf0d206b5953172`. The following changes are included: - Sort registry files by handle/ID. (WordPress/gutenberg#75755) - Obey undoIgnore flag in editEntityRecord (WordPress/gutenberg#76206) - RTC: Fix `post-editor-template-mode` E2E test (WordPress/gutenberg#76209) - Publish built Gutenberg plugin to the GitHub Container Registry (WordPress/gutenberg#75844) (WordPress/gutenberg#76273) - Connectors: Improve placeholder text and make it translatable (WordPress/gutenberg#75996) - Block context menu: context menu not closing for disconnecting unsynced pattern menu items (WordPress/gutenberg#75405) - Connectors: Improve responsive layout for small viewports (WordPress/gutenberg#76231) - theme.json schema: fix pseudo-class definition for button block (WordPress/gutenberg#76272) - Navigation block: fix submenu chevron toggle on touch devices (WordPress/gutenberg#76197) See #64595, #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61868 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 9, 2026
This updates the pinned hash from the `gutenberg` from `f4d8a5803aa2fbe26e7d9af4d17e80a622b7bab8` to `7b7fa2bc97a8029a302bd6511cf0d206b5953172`. The following changes are included: - Sort registry files by handle/ID. (WordPress/gutenberg#75755) - Obey undoIgnore flag in editEntityRecord (WordPress/gutenberg#76206) - RTC: Fix `post-editor-template-mode` E2E test (WordPress/gutenberg#76209) - Publish built Gutenberg plugin to the GitHub Container Registry (WordPress/gutenberg#75844) (WordPress/gutenberg#76273) - Connectors: Improve placeholder text and make it translatable (WordPress/gutenberg#75996) - Block context menu: context menu not closing for disconnecting unsynced pattern menu items (WordPress/gutenberg#75405) - Connectors: Improve responsive layout for small viewports (WordPress/gutenberg#76231) - theme.json schema: fix pseudo-class definition for button block (WordPress/gutenberg#76272) - Navigation block: fix submenu chevron toggle on touch devices (WordPress/gutenberg#76197) See #64595, #64393. Built from https://develop.svn.wordpress.org/trunk@61868 git-svn-id: http://core.svn.wordpress.org/trunk@61155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
dsas
added
the
[Feature] Patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix the block options (context) menu so it closes when the user clicks "Disconnect pattern" on an unsynced pattern.
Why?
Clicking "Disconnect pattern" in the block options menu (three-dot menu) did not close the dropdown for unsynced patterns. The menu stayed open, which was inconsistent with other menu items (e.g. "Edit section"), which do close the menu after the action.
How?
Pass
onClosefromBlockSettingsMenuControlsintoPatternsManageButton.Testing Instructions
Screenshots or screencast
Before
Kapture.2026-02-11.at.16.24.11.mp4
After
Kapture.2026-02-11.at.16.25.33.mp4