Add timestamp when publishing next versions#75293
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
I'm not a contributor so I cannot approve, but changes look good from my side. Thanks for tackling this 🚀 |
|
Size Change: 0 B Total Size: 2.99 MB ℹ️ View Unchanged
|
MaggieCabrera
pushed a commit
that referenced
this pull request
Feb 10, 2026
Co-authored-by: jsnajdr <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: LiamSarsfield <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated publishing of
nextversions is unreliable because we don't have the information we need to bump version likenext.v.0tonext.v.1. Thewp/nextbranch is completely overwritten withtrunkfiles before each publish, and thenext.v.0version is overwritten with the version fromtrunk. Then the Lerna versioning always starts fromv.0. And NPM publishing fails because the same version was already published.The solution is to add timestamp to the version number. It's an increasing number that can be generated independently, without knowing the previous version.
The version string should now look like
11.0.1-next.v.202602061304.0+5a627da981.This is a followup to #74589 which removed commit hash from the version string, because commit hashes don't sort correctly: a newer version is not lexicographically "higher" than an old version. Causes problem when updating usages of
nextversions.