Skip to content

Navigation overlay: fix default pattern contrast issue on dark themes#74979

Merged
MaggieCabrera merged 1 commit into
trunkfrom
fix-overlay-pattern-colors
Feb 2, 2026
Merged

Navigation overlay: fix default pattern contrast issue on dark themes#74979
MaggieCabrera merged 1 commit into
trunkfrom
fix-overlay-pattern-colors

Conversation

@MaggieCabrera
Copy link
Copy Markdown
Contributor

@MaggieCabrera MaggieCabrera commented Jan 27, 2026 •
edited
Loading

What?

This PR sets the text color of the overlay explicitly

Why?

The default pattern is not readable if the active theme has set a white color text

How?

By setting the color of the text to black, the way we do for the background

Testing Instructions

  1. Activate a theme that has a white text color
  2. Create a nav overlay
  3. The text should be black

Screenshots or screencast

Before After
Screenshot 2026-01-27 at 17 40 10 Screenshot 2026-01-27 at 17 40 04

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 27, 2026 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: MaggieCabrera <[email protected]>
Co-authored-by: scruffian <[email protected]>
Co-authored-by: mikachan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@MaggieCabrera MaggieCabrera self-assigned this Jan 27, 2026
@MaggieCabrera MaggieCabrera added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Jan 27, 2026
scruffian
scruffian approved these changes Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaggieCabrera MaggieCabrera enabled auto-merge (squash) January 27, 2026 16:47
mikachan
mikachan approved these changes Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaggieCabrera MaggieCabrera force-pushed the fix-overlay-pattern-colors branch from 9dd2efc to d2bbb30 Compare February 2, 2026 14:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026

Flaky tests detected in d2bbb30.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21593865370
📝 Reported issues:

@MaggieCabrera MaggieCabrera merged commit a59476d into trunk Feb 2, 2026
38 checks passed
@MaggieCabrera MaggieCabrera deleted the fix-overlay-pattern-colors branch February 2, 2026 15:02
@github-actions github-actions Bot added this to the Gutenberg 22.6 milestone Feb 2, 2026
adamsilverstein pushed a commit that referenced this pull request Feb 3, 2026
@MaggieCabrera @scruffian @adamsilverstein
fix the color of the overlay to fix contrast issues on dark themes (#…
30a3238 
…74979)

Co-authored-by: MaggieCabrera <[email protected]>
Co-authored-by: scruffian <[email protected]>
MaggieCabrera added a commit that referenced this pull request Feb 10, 2026
@MaggieCabrera @scruffian
fix the color of the overlay to fix contrast issues on dark themes (#…
889cdc0 
…74979)

Co-authored-by: MaggieCabrera <[email protected]>
Co-authored-by: scruffian <[email protected]>
@t-hamano t-hamano mentioned this pull request Mar 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scruffian scruffian scruffian approved these changes

@mikachan mikachan mikachan approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@MaggieCabrera MaggieCabrera

Labels

[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 22.6

Development

Successfully merging this pull request may close these issues.

3 participants

@MaggieCabrera @scruffian @mikachan