-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix: add border-box sizing for verse block #74722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: add border-box sizing for verse block #74722
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @EldarAgalarov. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Shekhar0109! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
#74722 and #74723 are not exclusive; they solve different problems. This PR resolves overflow when the left or right padding is applied to a block. Here is an example of the Verse block:
However, since the Search block doesn't support padding in the first place, @Shekhar0109, why did you add |
|
@t-hamano Thanks! I added That said, if Search doesn’t actually show any change right now (since it doesn’t support padding), I’m totally fine dropping the Search part and keeping the PR only for Verse. Just let me know what you prefer and I’ll update the PR. |
|
@Shekhar0109 Can we focus on the Verse block only in this PR? See #74717 (comment) for the reason. It would also be great if you could update the PR title and description. |
|
@t-hamano Sure! I’ll update this PR to focus on the Verse block only and adjust the PR title/description accordingly. Thanks for the guidance. |
|
@t-hamano Quick update: I’ve reverted the Search change, so this PR is Verse-only now, and updated the title/description accordingly. |
SirLouen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to find out the test instructions
I cannot see under which exact conditions this makes a thing. Definitely with the OP test conditions I can't see any difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.




What?
Closes #74717
Adds
box-sizing: border-boxfor the Verse block.Why?
The Verse block can overflow and not respect container max-width when padding is applied.
box-sizing: border-boxensures sizing stays within the container.How?
Adds
box-sizing: border-boxtopre.wp-block-verse.Testing Instructions