Merged
Conversation
mirka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
commented
Jan 16, 2026
|
|
||
| @layer wp-ui-compositions { | ||
| .wrapper { | ||
| --wp-ui-input-padding-block: 9.9px; |
Member
Author
Contributor
There was a problem hiding this comment.
I'm still thinking unit-less line height is more versatile, and it would allow us to have just a few values that can be combined with all font sizes if / when necessary.
If we want to use line height to establish an element's height, I'd be almost more inclined to use a size/height token for the line-height CSS property to really show what's the intent.
mirka
commented
Jan 16, 2026
Member
Author
There was a problem hiding this comment.
I'm adding more tests than the other primitives here, since we're doing a good amount of integration in the implementation.
Contributor
There was a problem hiding this comment.
Should we test disabled / rows attributes, or do we trust we don't have to test for those?
mirka
commented
Jan 16, 2026
packages/ui/CHANGELOG.md
Outdated
|
|
||
| ### New Features | ||
|
|
||
| - Add `Select` primitive ([#74661](https://github.com/WordPress/gutenberg/pull/74661)). |
Member
Author
There was a problem hiding this comment.
Fixing the misplaced changelog for Select.
|
Size Change: 0 B Total Size: 2.99 MB ℹ️ View Unchanged
|
aduth
approved these changes
Jan 27, 2026
| style={ style } | ||
| render={ wrappedRender( | ||
| render || ( ( props ) => <textarea { ...props } /> ), | ||
| { className: styles.textarea, ref, rows, ...restProps } |
Member
There was a problem hiding this comment.
Do these need to be applied here vs. the top-level component? Particularly className, ref, and restProps. Guessing rows could be a problem with the base component being typed for HTMLInputElement. Is there any way we can make it generic? Just trying to see if there's an option to avoid the wrapping logic.
Member
Author
There was a problem hiding this comment.
Basically yes. It's either this or we make the props for Input generic, which isn't inherently simpler, and also just less type safe. ref, rows, and restProps all need to be of a Textarea type. This is probably the only place where we'll be doing something like this, if that makes it more palatable 😅
className is not about types, but just that the classes on the render element go to a different element (<textarea> itself) from the top-level class (a wrapper div).
ciampo
reviewed
Feb 5, 2026
| }; | ||
| }; | ||
|
|
||
| export const Textarea = forwardRef< HTMLTextAreaElement, TextareaProps >( |
Contributor
There was a problem hiding this comment.
Should we add a JSDoc comment describing the component?
Member
Author
There was a problem hiding this comment.
I think I'll go in and add them for all the form primitives once the *Control versions are ready, so I can point to them in the description.
|
|
||
| @layer wp-ui-compositions { | ||
| .wrapper { | ||
| --wp-ui-input-padding-block: 9.9px; |
Contributor
There was a problem hiding this comment.
I'm still thinking unit-less line height is more versatile, and it would allow us to have just a few values that can be combined with all font sizes if / when necessary.
If we want to use line height to establish an element's height, I'd be almost more inclined to use a size/height token for the line-height CSS property to really show what's the intent.
Contributor
There was a problem hiding this comment.
Should we test disabled / rows attributes, or do we trust we don't have to test for those?
Contributor
There was a problem hiding this comment.
What's the deal with controlled components? Should we add an example?
Member
Author
There was a problem hiding this comment.
I don't know 🤔 It would get tedious to add controlled code samples for all components. Maybe we can have the code snippet in the JSDoc descriptions to all be controlled examples? Seems like that's what we do in @wordpress/components.
Contributor
There was a problem hiding this comment.
Yeah. Or otherwise have a MDX document at the top of the folder to explain controlled vs uncontrolled — should be feasible since all components in the package should follow the same value/defaultValue/onValueChange convention?
Member
Author
There was a problem hiding this comment.
all components in the package should follow the same
Aside from a minor deviation for checkboxes and switches (checked instead of value). I guess a JSDoc code snippet would be most straightforward, when accounting for this kind of difference.
Comment on lines
12
to
14
| if ( ! render ) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
This early return doesn't seem necessary, given how wrappedRender always receives a value for the render argument?
# Conflicts: # packages/ui/CHANGELOG.md
MaggieCabrera
pushed a commit
that referenced
this pull request
Feb 10, 2026
* UI: Add Textarea primitive * Add changelog * Add tests for disabled and rows * Remove unnecessary early return Co-authored-by: mirka <[email protected]> Co-authored-by: aduth <[email protected]> Co-authored-by: ciampo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #74178
Add
Textareaprimitive component to@wordpress/ui.Why?
This is a low-level primitive that will build up to an
TextareaControlequivalent.How?
It's a
Inputcomponent rendered as atextareaelement. This allows us to reuse the styles and API, which are largely the same. (Base UI currently has no independent Textarea component.)Testing Instructions
See stories in Storybook.
Screenshots or screencast