Skip to content

Change featured_media value to null on image removal #74660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pkevan wants to merge 1 commit into from
Closed

Change featured_media value to null on image removal #74660

pkevan wants to merge 1 commit into from

Conversation

@pkevan
Copy link
Contributor

@pkevan pkevan commented Jan 15, 2026 •
edited
Loading

What?

Closes #74657.

Allow featured_media to be reflected across multiple users.

Why?

With multiple users potentially editing posts at the same time, it is important to accurately reflect if a featured image has been removed.

How?

By switching to null, rather than 0 the update gets reflected.

Testing Instructions

  1. Open an edit post page with two users.
  2. User 1 can set a featured image
  3. User 2 should see this new image
  4. User 2 can then remove the new image
  5. User 1 should see that the image has been removed

Screenshots or screencast

Before:

Screen.Recording.2026-01-15.at.15.07.46.mov

After:

Screen.Recording.2026-01-15.at.15.10.39.mov

@pkevan pkevan added [Type] Bug An existing feature does not function as intended [Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration labels Jan 15, 2026
@github-actions
Copy link

github-actions bot commented Jan 15, 2026 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: pkevan <[email protected]>
Co-authored-by: chriszarate <[email protected]>
Co-authored-by: ingeniumed <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the [Package] Editor /packages/editor label Jan 15, 2026
@chriszarate
Copy link
Contributor

chriszarate commented Jan 15, 2026

Why does a 0 value affect multiple collaborators but not a single user? Does this intersect with sync code in some way?

@pkevan
Copy link
Contributor Author

pkevan commented Jan 15, 2026

Why does a 0 value affect multiple collaborators but not a single user? Does this intersect with sync code in some way?

The behaviour is invisible with only one editor, since their version looks correct.

@ingeniumed
Copy link
Contributor

ingeniumed commented Jan 15, 2026

There's a bunch of places in Gutenberg where if the featured_media doesn't have a value then it's set to 0. That'd suggest that, that is intentional behaviour?

This doesn't feel similar to the gallery block problem, where the blob was only present locally?

@pkevan pkevan mentioned this pull request Jan 20, 2026
Open
6 tasks
@pkevan pkevan closed this Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

[Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Featured Image: remove image does not get removed in collaborative editing

3 participants

@pkevan @chriszarate @ingeniumed