Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
[Package] Editor
|
Size Change: +10.8 kB (+0.35%) Total Size: 3.1 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/revisions-in-editor
branch
from
3ba17a4 to
6df4e6e
Compare
ellatrix
added
[Type] Enhancement
13 tasks
t's a simple reordering
ellatrix
force-pushed
the
try/revisions-in-editor
branch
from
ac43fb9 to
95c7d92
Compare
Contributor
|
I know this is a proof of concept but wanted to report a small bug with the dates where it seems to overflow and then not fit very well in the screen: revisions.movCurious in particular to test a post with a ton of revisions to see how this would scale! Super cool to see though and, for the most part seems to be working quite well. |
Member
Author
|
@annezazu That bug was fixed in the extracted PR #74771. As for the scaling, we have some more room to play with, we can expand a bit as the number grows. Worth noting we have the same issue in the current revisions screen which has a similar horizontal slider at the top. Another idea is to at some number break it up and add earlier/later buttons to navigate between time sections. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Preparatory work: #74771. This PR is just a proof of concept, please don't review.
Shows the revisions diff within the editor, and visually as blocks.
Why?
It's high time revisions can be seen without leaving the editor.
How?
Testing Instructions
Revisions can still be accessed through the same document inspector link.
Testing Instructions for Keyboard
Screenshots or screencast